On Sun, Apr 22, 2007 at 08:17:10AM +0200, Eric Y. Kow wrote: > On Sat, Apr 21, 2007 at 15:47:26 -0700, David Roundy wrote: > > Here's the next take on the stuff for Issue434. > > For what it's worth, this is going into unstable.
Yay. > > - - let pre_changed_files = apply_to_filepaths True (invert changes) > > files in > > + let pre_changed_files = apply_to_filepaths (invert changes) files in > > Shouldn't this be (runTolerantly $ apply_to_filepaths (invert changes) > files)? I'm not sure (without enough context), but I think apply_to_filepaths by definiton uses its own monad (which is totally unrelated to IO, and thus also unrelated to TolerantIO). > > instance WriteableDirectory TolerantIO where > > mWithCurrentDirectory = mInCurrentDirectory > > > +instance WriteableDirectory SilentIO where > > + mWithCurrentDirectory = mInCurrentDirectory > > The duplication might not be so bad. The reason is that some things you > might not actually want to be silent. For example, if you remove a > directory and do not suceed, no big deal; however, you add a file and > fail, maybe you really do want to know about that, quiet or no. Possibly, but then we'd always have the possibility of a bug being fixed in one monad but not the other. It's simple enough stuff that probably there won't be many bugs found, and provided we're worried about it, it may never happen, but it still concerns me. -- David Roundy http://www.darcs.net
signature.asc
Description: Digital signature
_______________________________________________ darcs-devel mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-devel
