On Wed, May 30, 2007 at 09:19:15PM +0200, Eric Y. Kow wrote: > I realise that it was me that requested you sent the patch (for which, > thanks; had completely forgotten about it), but I'm started to have > second thoughts here. > > On Thu, May 24, 2007 at 02:58:58 +0200, Misha Aizatulin wrote: > > Thu May 24 01:42:32 CEST 2007 Misha Aizatulin <[EMAIL PROTECTED]> > > * fix scp whitespace > > > > see http://bugs.darcs.net/issue454 > > > + tr ' ' = "\\ " > > On the one hand, we already escape dollar without really knowing why, so > I guess this isn't that much scarier (although I would rename that > escape_dollar to something else and update the comment). On the other > hand, I'm a bit disturbed about adding this kind of stuff without having > some kind of justification. I've tried searching from some kind of > documentation on this, but have only uncovered some random complaints > about whitespace in filenames in OpenSSH's scp as well as a patch to fix > such problems... but no replies, so not sure where to go with this. > > Tommy?
I was thinking exactly the same, but yesterday I decided to push this patch to darcs-stable, so it's already in there. It's still posible to do a rollback if you want. My only worry is if the patch will break something, but I havn't found any indications that it would. -- Tommy Pettersson <[EMAIL PROTECTED]> _______________________________________________ darcs-devel mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-devel
