On Tue, Jun 12, 2007 at 21:05:11 -0700, David Roundy wrote: > Here's the next installment of the gradual march towards type > witnesses.
Exciting!
Here's the current compilation error:
src/Darcs/Patch/Show.lhs:34:26:
Module `Darcs.Patch.Core' does not export `unsafeUnFL'
Do you guys want this stuff in despite the compilation errors?
(compiles fine without --with-type-witnesses)
I should read (p1 :< p2) as p1 before p2, right?
Also, I wonder if we want
:< and
:>: to be different directions...
> hunk ./src/Darcs/Patch/Depends.lhs 419
> - Just (p', fir') -> ctt (p':las) fir' ps
> - cmt_by :: ([Patch], Patch) -> Maybe (Patch, [Patch])
> - cmt_by (ps, a) = do (a', jps') <- commute (join_patches ps, a)
> - return (a', flatten jps')
> + Just (p' :> fir') -> ctt (p':las) fir' ps
> + cmt_by :: [Patch] :> Patch -> Maybe (Patch :> [Patch])
> + cmt_by (ps :> a) = do (a' :> jps') <- commute (join_patches ps :> a)
> + return (a' :> flatten jps')
Should commute_to_end give (Patch, Patch) or (Patch :< Patch)?
> -mapFL :: (FORALL(w y) a C(w,y) -> b C(w,y)) -> FL a C(x,z) -> FL b C(x,z)
> -mapFL _ NilFL = NilFL
> -mapFL f (a:>:as) = f a :>: mapFL f as
> +mapFL_FL :: (FORALL(w y) a C(w,y) -> b C(w,y)) -> FL a C(x,z) -> FL b C(x,z)
> +mapFL_FL _ NilFL = NilFL
> +mapFL_FL f (a:>:as) = f a :>: mapFL_FL f as
> +
> +mapFL :: (FORALL(w z) a C(w,z) -> b) -> FL a C(x,y) -> [b]
> +mapFL _ NilFL = []
> +mapFL f (a :>: b) = f a : mapFL f b
Hmm... maybe mapFL should give FL, and something like mapFL_List should give []
Seems more intuitive anyway.
Also, you might find something like a concatMapFL handy.
--
Eric Kow http://www.loria.fr/~kow
PGP Key ID: 08AC04F9 Merci de corriger mon français.
pgpobNZFWkdOz.pgp
Description: PGP signature
_______________________________________________ darcs-devel mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-devel
