On Tue, Feb 05, 2008 at 03:30:23AM +0300, Dmitry Kurochkin wrote:
> Some fixes and cleanups for configure checks.
> 
> And fix for copyRemotesNormal - if we use copyUrlFirst the first patch
> is downloaded last. So we lock in waitUrl and progress indication stops.

Thanks for these changes! Applied.  (once they pass tests and all that)

> Tue Feb  5 02:59:06 MSK 2008  Dmitry Kurochkin <[EMAIL PROTECTED]>
>   * Append CPPFLAGS to GHCFLAGS in autoconf.mk.in instead of configure.ac.
> 
> Tue Feb  5 03:01:09 MSK 2008  Dmitry Kurochkin <[EMAIL PROTECTED]>
>   * Fix configure check for curl_multi_timeout.

Very nice! I'd suspected this would reduce the amount of code considerably,
but I hadn't expected quite *this* much.  :)

> Tue Feb  5 03:07:17 MSK 2008  Dmitry Kurochkin <[EMAIL PROTECTED]>
>   * Cleanup curl pipelining configure check.
> 
> Tue Feb  5 03:18:41 MSK 2008  Dmitry Kurochkin <[EMAIL PROTECTED]>
>   * Cleanup libwww configure check.
> 
> Tue Feb  5 03:21:42 MSK 2008  Dmitry Kurochkin <[EMAIL PROTECTED]>
>   * Use copyUrl in copyRemotesNormal.

The only downside of this fix is that it means that we download all
"speculatively" scheduled files before any of those that are needed
strictly.  I don't think this is a real problem, because copyRemotes is
rarely used, and I don't think ever follows speculative downloads.  But I
do think a more correct approach might be to do something like copyUrlFirst
on the reverse of the list.  Although that'll also have issues of getting
the files-already-downloaded count off by five or so...
-- 
David Roundy
Department of Physics
Oregon State University
_______________________________________________
darcs-devel mailing list
darcs-devel@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-devel

Reply via email to