On Fri, 8 Feb 2008, David Roundy wrote:
> On Thu, Feb 07, 2008 at 08:46:21PM -0500, Mark Stosberg wrote:
>> Thu Feb 7 20:44:40 EST 2008 Mark Stosberg <[EMAIL PROTECTED]>
>> * copy over updated "shell_harness" to bugs.
>> Besides giving more consistent results, this is necessary for me to
>> be able to run the "broken-pipe.sh" test from a directory with a space
>> in it.
>
> I'm not clear as to why this change is needed. It looks like you're
> causing the bug shell test to fail, which is precisely the opposite of what
> it's intended to do. Perhaps you could figure out which of these changes
> are actually wanted?
David,
I'm sure we want the harnesses to be exactly the same. For example, the
regular tests can now be run from within a directory with a space in,
which we want, and we want scripts in the "bugs" directory work the same
way. Otherwise, cases like the one I ran into, where a test in the
"bugs" directory fails, but not for the reason the tester intended, but
because essentially the infrastructure is buggy.
I can think of *no* benefits of having the bugs harness be different
than the normal test harness. the bugs harness started out life being
copied over from the tests/ directory, and I was just trying to keep it
up to date.
Of course I want tests in bugs/ to fail, but I want them to fail because
there are bugs in the test, not in the harness.
Mark
--
http://mark.stosberg.com/
_______________________________________________
darcs-devel mailing list
darcs-devel@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-devel
