On Mon, Jul 25, 2005 at 07:59:57PM +0000, Nimrod A. Abing wrote:
> 
> Is there some way that I could have "marked" those rejected patches as
> "unexportable" so that subsequent pulls would no longer prompt me if I
> want to apply those patches? Is this feature implemented? If not then
> I suggest these new features:

This is bug #37, and your idea is basically what I had in mind (ever so
long ago).  It was discussed long, long ago, which is probably why you had
trouble finding it on the lists.  It would be a good thing, but isn't very
high priority for me.

> First one is a new option to darcs pull prompt. Example prompt:
> 
> Shall I pull this patch? (1/18) [yniWvpxqadjk], or ? for help:
> How to use pull...
> y: pull this patch
> n: don't pull it
> i: ignore this patch in future pulls <---- new option

I think I'd make this

i: ignore this patch in the future

since I'd rather have just one ignore list, which applies to pushes, pulls,
sends, unpulls, etc.

> w: wait and decide later, defaulting to no
> 
> v: view this patch in full
> p: view this patch in full with pager
> x: view a summary of this patch
> 
> d: pull selected patches
> a: pull all the remaining patches
> q: cancel pull
> 
> j: skip to next patch
> k: back up to previous patch
> h or ?: show this help
> 
> <Space>: accept the current default (which is capitalized)
> 
> Once you mark the patch as ignored, it will no longer be prompted to
> you the next time you pull from the same repository. You can also
> supply an option --show-ignored-patches to the pull command if you
> want to be prompted again. The ignored patches could be tracked in
> _darcs/patches/ignored

I'd rather track them in _darcs/prefs/ignored_patches, since that's a
user-modifiable directory.

> Second one is a "ignored-patches" command or somesuch. Options could be:
> 
> --list (default) shows a list of ignored patches sorted by repository.
> --remove=<patch-name> removes a patch from the ignore list.
> 
> and all the usual common options.

If we stick these things in _darcs/prefs/ (and document them), we could
make the user do this himself, which seems better than adding a new
command.  I'm imagining this file would be formatted basically like
_darcs/inventory, which while it isn't optimal, is pretty human-readable.
And the docs should state that users should feel free to just delete the
file to remove all ignore state.

I'd also add a flag --dont-ignore-any-patches to all the commands that
might listen to the ignore file.

> I think this will be very useful in situations where you need to fork
> your codebase (which I do a lot) but still want to be able to pull
> from the source of the forks.

It's also useful for patches you don't want to send.
-- 
David Roundy
http://www.darcs.net

_______________________________________________
darcs-users mailing list
[email protected]
http://www.abridgegame.org/mailman/listinfo/darcs-users

Reply via email to