When the darcs repository include commit messages which are not in
ASCII or UTF-8, darcs changes --xml send badly-formed XML (see issue
33 on the darcs bug tracker) and darcsweb crashes when parsing.
The following patch seems to cure the problem.
New patches:
[Add the XML decleration that darcs does not add
[EMAIL PROTECTED] {
hunk ./darcsweb.cgi 20
+import tempfile
hunk ./darcsweb.cgi 700
- xmlf = run_darcs("changes --xml-output " + params)
+ raw_xml = run_darcs("changes --xml-output " + params)
+ xmlf = tempfile.TemporaryFile()
+ # Add the XML declaration. darcs should do it but does not. See issue 33
+ # on bugs.darcs.net.
+ xmlf.write('<?xml version="1.0" encoding="%s"?>\n' %
config.repoencoding)
+ xmlf.write(raw_xml.read())
+ raw_xml.close()
+ xmlf.seek(0)
hunk ./darcsweb.cgi 709
- xmlf.close()
-
}
Context:
[fixu8: honour config.repoencoding when decoding characters like [_\e3]
Kirill Smelkov <[EMAIL PROTECTED]>**20051130113626]
[another basic validation issue
Alexandre Rossi <[EMAIL PROTECTED]>**20051112235916
The issue was that there was an empty line before the XML declaration, which
is not valid.
]
[Make how_old() return a fixed date when caching is enabled.
Alberto Bertogli <[EMAIL PROTECTED]>**20051117144133
how_old() becomes a problem when we have a cache, because the relative dates
will get stalled in the cache.
This is makes a workaround by making how_old() return a string containing the
fixed date, which isn't quite nice but it will do the trick until a better
solution comes up.
]
[Don't close the file in a cache miss.
Alberto Bertogli <[EMAIL PROTECTED]>**20051117144027]
[Call cache.cancel() only if we have a cache.
Alberto Bertogli <[EMAIL PROTECTED]>**20051117032757]
[Implement a simple cache.
Alberto Bertogli <[EMAIL PROTECTED]>**20051117031028
This patch implements a very simple but effective cache, so darcsweb can avoid
regenerating everything all the time.
Based on an idea from Alexandre Rossi.
]
[Use a more human-friendly format por list configuration variables.
Leandro Lucarella <[EMAIL PROTECTED]>**20051110152239]
[Highlight tags in the shortlog/summary.
Alberto Bertogli <[EMAIL PROTECTED]>**20051110003434]
[Add exclusion lists to multidir configuration.
Alberto Bertogli <[EMAIL PROTECTED]>**20051109235947]
[TAG 0.12
Alberto Bertogli <[EMAIL PROTECTED]>**20051109011031]
Patch bundle hash:
e456be38e6e3275be6231bd86bbe663cd6d3d021
_______________________________________________
darcs-users mailing list
[email protected]
http://www.abridgegame.org/mailman/listinfo/darcs-users
