On Dec 22, 2005, at 2:22 AM, Lee Begg wrote:

On Thu, 22 Dec 2005 20:07, Jason Dagit wrote:

I was going to say...That was the whole reason I implemented
posthooks. I hope you enjoy them. Let me know if they need polishing.

Good luck,
Jason

The only thing that surprised me was that it was run only once.  I had
expected it to be run for each patch. (My posthook still doesn't take this
into account yet).

Ah, yes. That behavior is for several reasons, 1) it was easier to implement, 2) that's what I needed, 3) darcs views the push of multiple patches as one single apply. What would you recommend as a fix for this? I want to preserve the current behavior, but the once per patch behavior would be very nice as well. When I say fix, I don't mean way of implementing it, but I mean a way of communicating your intent to darcs.


I had thought there might have been arguments given to it (say, the number of patches or their names, or something) and/or input on standard in. It should
be documented that there is no input given to the posthook.

There was quite a bit of discussion about this on the darcs-devel list this summer. If I recall correctly, the favored plan was to use environment variables to pass this information. We discussed using files, standard io, and env variables. Each way has strengths and weaknesses. Which way would have worked best for you?


It is very helpful though. Works well. A touch more documentation, and maybe
an example or two of what you can do with them wouldn't hurt.

Thanks. I'll make a note of the documentation. I have at least one more example that needs to be included. I can touch up the wording about how often the posthook will run.

Thanks,
Jason


_______________________________________________
darcs-users mailing list
[email protected]
http://www.abridgegame.org/mailman/listinfo/darcs-users

Reply via email to