Will wrote:

Hello,

David Roundy <[EMAIL PROTECTED]> writes:

On Sat, Jan 07, 2006 at 09:04:16AM +0100, Marnix Klooster wrote:
Hi all,

Two things seem wrong here: first the type is not application/rss+xml; but more importantly the last line ("Posthook ran successfully") make it invalid XML.

Thanks for catching this!  I've sent in a patch to output the proper
RSS content-type.

They both sound like bugs, but I'm not sure about the former (which would
be in darcs.cgi itself).  The latter issue I'd say is definitely a bug.  We
shouldn't be printing "Posthook ran successfully" to stdout when printing
stuff to stdout.  Perhaps it should always go to stderr?

I'd be in favor of eliminating the output on success; it would annoy me
to see that message after every command =)


Agreed. Usually UNIXy tools tell you only when something's *wrong*... on stderr :-)

Groetjes,
<><
Marnix

_______________________________________________
darcs-users mailing list
[email protected]
http://www.abridgegame.org/mailman/listinfo/darcs-users

Reply via email to