I'd rather see these tests either removed or moved to bugs/. The
choice can be made on a case-by-case basis.
David
On Wed, Aug 06, 2008 at 10:27:15AM -0700, Simon Michael wrote:
> Here is a start at implementing yesterday's suggestion. "make test" now
> gives clean output for me on a mac (yay!)
>
> Simon Michael wrote:
> >As I was learning about the darcs test suite today, I was confused by
> >the output of test TODOs. Eg:
> >
> >$ perl merging_newlines.pl
> >ok 1 - reality check: manifest
> >ok 2 - reality check: darcs w -s
> >ok 3 - expect conflicts when pushing
> >not ok 4 - after a conflict, darcs resolve should report a conflict #
> >TODO waiting on code to fix this
> ># Failed (TODO) test 'after a conflict, darcs resolve should report a
> >conflict'
> ># at merging_newlines.pl line 48.
> ># 'No conflicts to mark.
> ># '
> ># matches '(?i-xsm:no conflicts)'
> >1..4
> >
> >When run en masse, it looks like this:
> >
> >merging_newlines.......................1/?
> ># Failed (TODO) test 'after a conflict, darcs resolve should report a
> >conflict'
> ># at merging_newlines.pl line 48.
> ># 'No conflicts to mark.
> ># '
> ># matches '(?i-xsm:no conflicts)'
> >merging_newlines.......................ok
> >
> >So as I understand it the merging_newlines test passed, but printed this
> >(scary) output as a reminder to developers. My reaction as a newbie
> >darcs tester is that these don't belong here, because
> >
> >- they make it harder for testers to see whether tests passed
> >
> >- they nag too many people - testers should not be bothered with random
> >things that developers hope to do some day
> >
> >- they are another mechanism for documenting tests known to fail, which
> >we already have in bugs/*
> >
> >I would propose that these kinds of TODO items be made silent
> >(developers know how to grep) and/or be moved to the bugs/* tests. What
> >do you think ?
> >
> >-Simon
>
> Wed Aug 6 10:16:13 PDT 2008 Simon Michael <[EMAIL PROTECTED]>
> * comment out (most) TODO sections in tests for clean output
>
> New patches:
>
> [comment out (most) TODO sections in tests for clean output
> Simon Michael <[EMAIL PROTECTED]>**20080806171613] hunk ./tests/add.pl 62
> -TODO: {
> - local $TODO = 'waiting on coding';
> - my $test_name = "add should fail on files it can't read (because it
> would fail to record it later anyway).";
> - touch "no_perms.txt";
> - chmod(0000,"no_perms.txt");
> - like(darcs(qw(add no_perms.txt)), qr/permission denied/,$test_name);
> - rm_rf "no_perms.txt";
> +# TODO: {
> +# local $TODO = 'waiting on coding';
> +# my $test_name = "add should fail on files it can't read (because it
> would fail to record it later anyway).";
> +# touch "no_perms.txt";
> +# chmod(0000,"no_perms.txt");
> +# like(darcs(qw(add no_perms.txt)), qr/permission denied/,$test_name);
> +# rm_rf "no_perms.txt";
> hunk ./tests/add.pl 70
> -}
> +# }
> hunk ./tests/dist.pl 17
> -TODO: {
> - local $TODO = "needs fixed on FreeBSD" if ($^O eq 'freebsd');
> - unlike( darcs("dist -v"), qr/error/i, "darcs dist -v avoids error
> message " );
> -}
> +# TODO: {
> +# local $TODO = "needs fixed on FreeBSD" if ($^O eq 'freebsd');
> +# unlike( darcs("dist -v"), qr/error/i, "darcs dist -v avoids error
> message " );
> +# }
> hunk ./tests/merging_newlines.pl 46
> -TODO: {
> - local $TODO = 'waiting on code to fix this';
> - unlike(darcs(q(resolve)),qr/no conflicts/i, "after a conflict, darcs
> resolve should report a conflict");
> -}
> +# TODO: {
> +# local $TODO = 'waiting on code to fix this';
> +# unlike(darcs(q(resolve)),qr/no conflicts/i, "after a conflict, darcs
> resolve should report a conflict");
> +# }
>
> Context:
>
> [small makefile refactoring: allow just the normal tests to be run, without
> bugs/*
> Simon Michael <[EMAIL PROTECTED]>**20080805203242]
> [Rectify dist help
> [EMAIL PROTECTED]
> Removed the "make dist" suggestion, the manual is a better place for that.
> Instead, make clear that it operates on a clean copy of the tree, and
> mention the "predist" functionality.
> ]
> [Canonize Gaetan Lehmann and Daniel Buenzli.
> Eric Kow <[EMAIL PROTECTED]>**20080730104357
> (for Daniel B, avoid an accent in his name)
> ]
> [configure: check for packages needed with split base.
> Eric Kow <[EMAIL PROTECTED]>**20080730103840
> Now that all packages must be used explicitly.
> ]
> [fix type witness compile errors specific to ghc 6.8
> Jason Dagit <[EMAIL PROTECTED]>**20080722182729]
> [website: explain that darcs 2 is required to get the darcs source.
> Simon Michael <[EMAIL PROTECTED]>**20080803181216]
> [avoid import of unused function fromMaybe.
> David Roundy <[EMAIL PROTECTED]>**20080729172825]
> [configure: suggest regex-compat before text
> Eric Kow <[EMAIL PROTECTED]>**20080725095336]
> [configure: mention Haskell in 'try installing' suggestion
> Eric Kow <[EMAIL PROTECTED]>**20080725095015]
> [Typo (Text.Regex)
> Eric Kow <[EMAIL PROTECTED]>**20080715121708]
> [Use haskeline to have a readline-like behavior when asking something to the
> user
> [EMAIL PROTECTED]
> Unlike the implementations using readline or editline packages, this code
> code doesn't break the Ctrl-C behavior.
> ]
> [Improve generic rules for English plurals.
> Eric Kow <[EMAIL PROTECTED]>**20080604123728]
> [add configure check for Network.URI.
> David Roundy <[EMAIL PROTECTED]>**20080711011914]
> [add -hide-all-packages to default GHCFLAGS.
> David Roundy <[EMAIL PROTECTED]>**20080711010952]
> [add support for outputting patch numbers in darcs changes.
> David Roundy <[EMAIL PROTECTED]>**20080710011211]
> [add support for matching single patches by index.
> David Roundy <[EMAIL PROTECTED]>**20080710004512]
> [add support for matching ranges of patches (counting back from present).
> David Roundy <[EMAIL PROTECTED]>**20080710003225]
> [Better avoid silly manpage error.
> Trent W. Buck <[EMAIL PROTECTED]>**20080704024920
>
> It turned out only initialize's help string used 'quotes', so just
> remove them. This makes init's docstring consistent with the others.
> ]
> [Missing period at end of sentence.
> Trent W. Buck <[EMAIL PROTECTED]>**20080704024232]
> [darcs --overview no longer works, so don't document it.
> Trent W. Buck <[EMAIL PROTECTED]>**20080704030804]
> [Avoid silly manpage error.
> Trent W. Buck <[EMAIL PROTECTED]>**20080703010733
> man (nroff) treats an apostrophe in the first column specially,
> resulting in a syntax error without this patch.
>
> Ideally, all cases of 'foo' in the manpage (i.e. docstrings) should
> become `foo', since man -Tps turns ` and ' into left and right single
> quotes respectively.
> ]
> [obliterate whitespace in Darcs.Commands.Get
> [EMAIL PROTECTED]
> 'twas causing lhs/haddock difficulties where a \end{code} wasn't getting
> recognized.
> ]
> [rm haddock CPP business
> [EMAIL PROTECTED]
> Try as I might, I can't see any reason to special-case some Haddock CPP
> logic to deal with some *commented-out guards*, unless CPP magically restores
> and uncomments the code if Haddock isn't being run.
> ]
> [make pull less verbose when --verbose flag is given.
> David Roundy <[EMAIL PROTECTED]>**20080624170035]
> [fix makefile to remember to regenerate version information after running
> configure.
> David Roundy <[EMAIL PROTECTED]>**20080624170001]
> [TAG 2.0.2
> David Roundy <[EMAIL PROTECTED]>**20080624012041]
> Patch bundle hash:
> 6ab782f65204be01ed83a0277b5b5890ab2e04d6
--
David Roundy
Department of Physics
Oregon State University
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
