On Tue, Aug 12, 2008 at 03:33:33AM +0200, [EMAIL PROTECTED] wrote:
> Hi,
>
> this is an amended version of the repair patches for issue971 I have
> previously
> sent. They should address most of the review comments -- or so I hope.
> However,
> they do not address the failing test (I haven't investigated yet) and they do
> not improve the heuristic on how often to dump the slurpy to disk (still every
> 100 patches). I intend to improve on those two later this week -- I need to
> crash to bed again now.
>
> (I have found a bug as well, where we have missed that files went missing from
> pristine -- this has been there before, although it's much harder to get this
> kind of corruption in hashed pristine I guess (rm'd files reappear thanks to
> laziness no problem, one of the directory listings would have to get corrupted
> somehow). Nevertheless, we catch that now as well, hopefully without bad
> side-effects.)
>
> Yours,
> Petr.
>
> Tue Aug 12 02:21:14 CEST 2008 [EMAIL PROTECTED]
> * Parametrize "pristine.hashed" in a bunch of functions.
>
> Tue Aug 12 02:23:45 CEST 2008 [EMAIL PROTECTED]
> * Add writeSlurpy to roll out a copy of slurpy into a filesystem.
>
> Tue Aug 12 02:27:08 CEST 2008 [EMAIL PROTECTED]
> * Generalize HashRepo.clean_pristine to HashIO.clean_hashdir.
I've reviewed up to here and am applying these. They don't benefit
much on their own, but they look good.
> Tue Aug 12 02:38:10 CEST 2008 [EMAIL PROTECTED]
> * Add forceHashSlurped that hashes the slurpy even if it already contains
> hashes.
I'm still unclear as to the purpose of forceHashSlurped...
And now I need to go get ready for my day.
> Tue Aug 12 02:50:39 CEST 2008 [EMAIL PROTECTED]
> * Add Repository.checkPristineAgainstSlurpy.
>
> Tue Aug 12 02:54:23 CEST 2008 [EMAIL PROTECTED]
> * First working (albeit slow) version of repair that uses hashed
> newpristine.
>
> Tue Aug 12 03:06:03 CEST 2008 [EMAIL PROTECTED]
> * Only "update" (sync to disk) the slurpy every 100 patches.
>
> Tue Aug 12 03:25:24 CEST 2008 [EMAIL PROTECTED]
> * Add Repository.replacePristineFromSlurpy.
>
> Tue Aug 12 03:27:20 CEST 2008 [EMAIL PROTECTED]
> * Fix checkPristineAgainst{Cwd,Slurpy}: we ignored files missing in
> pristine.
>
> Add LookForAdds to smart_diff options to fix that and also throw in
> IgnoreTimes
> for a good measure and extra paranoia.
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
