On Wed, Aug 13, 2008 at 10:48 AM, David Roundy <[EMAIL PROTECTED]> wrote:
> Hi Jason, > > I've applied the first two of these, but not the rest, since I ran out > of time for reviewing. I'll take a look at the rest later. The first > two look good. One thing I noticed in Choices was that it would be > nice to remove the separate_first_middle_from_last and friends, now > that we've got your improved get_choices. The "separate" functions > were written to provide a "safer" interface for get_first_changes and > friends, but at this point I think it'll be clearest to just use > get_choices, which makes the "first", "middle" and "last" explicit in > the type. (But this needn't be something that is fixed soon...) Ah, I was wondering about that myself. I'll put it on a TODO list. Thanks, Jason
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
