Applied, thanks! On Fri, Aug 29, 2008 at 09:42:50PM +0100, Ganesh Sittampalam wrote: > Hi David, > > Apologies for the lack of explanatory text; editor incompetence meant I > accidentally sent it too soon. > > This patch adds support for the Haskell zlib package, as an alternative > to the C zlib. The main reasons this is useful are: > > - Makes building darcs on native (i.e. non-cygwin/mingw) windows a bit > easier. On most platforms the haskell zlib just links against -lz, but > for Windows it actually includes the sources of a specific version, > so it builds without any problems. > > - Outsourcing the job of gunzipping/gzipping bytestrings to zlib is a > good idea in any case, as its not a job that is specific to darcs. It > will also make a future switch to lazy bytestrings easier, if we wanted > to do that.
Sounds good to me. > Currently it is slightly inefficient on reading large patches, as these > get copied in memory. As the comment by the actual bit of code in the > patch reading bit says, this will be improved once a new interface is > added to zlib to allow us to say what size the uncompressed patch will > be. I've sent Duncan Coutts a patch to do this and am just waiting for > him to integrate it, but I'd rather get the basic support in now to avoid > future merge conflicts, since it does work. Most patches are small enough > to fit in one chunk, so I don't think the performance impact will be > significant. In any case the C zlib remains the default. Could you add a test that bytestring is being used? I imagine the Haskell zlib requires bytestring, so we know it's present, but it looks like in the obscure case where a user configures with --disable-c-zlib and --disable-bytestring, they'll get a compile error rather than a configure error, which is suboptimal. > Cheers, > > Ganesh > > On Fri, 29 Aug 2008, Ganesh Sittampalam wrote: > >> Fri Aug 29 21:30:32 BST 2008 Ganesh Sittampalam <[EMAIL PROTECTED]> >> * add option to use Haskell zlib package >> _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
