Contributing to the review. On Tue, Sep 02, 2008 at 01:41:25 +0200, [EMAIL PROTECTED] wrote: > (As for cabalisation, the current primary aim is to get native Windows builds > more easily.
Cabalisation or no, I think the general trend of allowing Haskell packages to one day replace our own C bindings is a positive trend. It will make our code cleaner one day, and will help more people to build darcs. > -getTermNColors :: IO CInt > +getTermNColors :: IO Int At first I was wondering why you could just change the type like that, but then I saw that our only use of getTermNColors (in ColorPrinter) basically just expects any instance of Ord. As a nitpick, I think I would have done this in two patches, one that does the type-refactor, and one that adds the new terminfo functionality. > Ganesh Sittampalam <[EMAIL PROTECTED]>**20080901060519] hunk ./configure.ac > 548 > fi > fi > > -dnl Check for libcurses... > +dnl Check for libcurses/terminfo... With Ganesh's changes, we still prefer libcurses, only using terminfo if (a) curses is not available (b) terminfo is available and (c) the user has not explicitly deselected it. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpVntu1MdqjX.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
