On Thu, Sep 4, 2008 at 1:18 PM, David Roundy <[EMAIL PROTECTED]> wrote: > On Wed, Sep 03, 2008 at 11:48:40PM +0200, [EMAIL PROTECTED] wrote: >> Hi, >> >> sorry about unwieldly big bundle, the last 4 patches are the interesting >> part: >> the rest got pulled in by dependencies... >> >> Now, since I'm already running around Cache, HashedIO and friends with a >> broom, >> I have removed most of the [DarcsFlag] instances in there, with the finding >> that the only thing that's actually used down the stack is "NoCompress". I >> have >> converted these to use a dedicated type. Hopefully, that's a step in right >> direction... (At very least, it documents what is needed where.) >> >> I would generally like to push [DarcsFlag] use as high in the stack as >> reasonably possible, hopefully all the way to the UI layer. The core has no >> business dealing with that kind of wholesale information. (If noone minds, >> I'd >> go on with stripping [DarcsFlag] from smart_diff, as that looks like a good >> target to me -- a purely intuitive selection, though...) > > Applied. Thanks! (And I'd want to do a behavior change in > smart_diff, so if you can wait on that until we've had time to talk, > that would be great.)
I just pulled and recorded a patch on top of my local changes to fix the conflicts and I'm about to resend my patches (just waiting for the test suite to pass). Jason _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
