Tis test passes and seems to make sense, so I have fast-tracked it into stable.
But do please have a look at tests/README.test_maintainers.txt for tips
on improving tests.
> +#!/bin/sh
For some reason we have decided to switch to explicit uses of bash.
> +binary=mybinary.jpg
> +function checkbinary(){
> + cmp $binary ../temp1/$binary
> +}
The test suites is one place where we generally frown on highly factored
code.
I think one reason we avoid defining functions is to make it easy to
determine where a test fails, and also to increase copy and pastability.
I say this because I have written my fair share of 'factored' tests in
darcs and paid the price of future "huh?" :-)
> +test ! -e $binary
> +darcs unrevert -a
> +checkbinary
I might also cleanup the tempdirs at the end.
Thanks!
--
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
pgpzVDENmvTRq.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
