On Mon, Sep 08, 2008 at 02:12:46 +0400, Dmitry Kurochkin wrote:
> I see to important HTTP related issues: 996 and 1035. Did I forget anything?

Perhaps issue876?  I guess we've known about this one for a while, and
we wouldn't be making it any worse.

> 1) leave pipelining enabled by default, raising minimal curl version
> check for pipelining in configure to (unreleased) 7.19.1
> 2) leave configure check as is, disable pipelining by default, add
> --enable-pipelining flag

So, some possible things to factor in:

 * even when libcurl 7.19.1 is released, it will take a while
   before it makes it into people's OS distributions
 * pipelining works for most people (?) even with older libcurl.
   It's just that when it does not work, the results seem pretty dire
   (mystery hanging)

It seems like we really want people to try pipelining, but only on an
opt-in basis.  So we should make it easy for people to try it out, but
not obligatory.

Option 1.5 might be to leave the configure check as it is (making it
easy), but switch the runtime options so that pipelining is disabled by
default (making it opt-in).  You would then get two runtime flags:

 --http-pipelining
 --no-http-pipelining [*]

For most users, pipelining would be disabled, but for those adventerous
few who read ChangeLogs and who notice that there is this new
experimental feature which makes http stuff go faster if you put all
http-pipelining in your ~/.darcs/prefs, pipelining would be enabled.
That's my two pence anyway.

One disadvantage with this scheme is that the relationship between the
configure and runtime flags might be confusing (--http-pipelining
doesn't do anything if --disable-pipelining is passed to configure).

[*] I'm only using 'no' instead of 'disable' because other switches
    do it, not because I feel there is a particular reason otherwise

> 3) leave everything as is, add a note in readme (or elsewhere) that
> with proxy --disable-pipelining flag may be required

That makes me nervous.  We should play it safe when it comes to
documentation, i.e. assume that people generally do not read it :-)

> 4) implement a runtime check for proxy configuration and disable pipelining

Interesting idea.

Thanks!

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: pgphKGD8oDC6r.pgp
Description: PGP signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to