On Mon, Sep 08, 2008 at 11:02:28AM -0700, Dmitry Kurochkin wrote: > Mon Sep 8 21:57:26 MSD 2008 Dmitry Kurochkin <[EMAIL PROTECTED]> > * Add -[-no]-http-pipelining options, disable pipelining by default for > curl < 7.19.1.
Applied (with a couple patches making extra modifications). Thanks! > hunk ./src/Darcs/Commands/Changes.lhs 93 > - command_advanced_options = [ssh_cm, > disablePipelining], > + command_advanced_options = [ssh_cm], ... > hunk ./src/Darcs/Commands/Convert.lhs 98 > - command_advanced_options = [ssh_cm, disablePipelining], > + command_advanced_options = [ssh_cm], It would be a nice little refactor to define a new function networkingOptions which includes both the ssh_cm and disablePipelining options, so then in the future if we want to add or remove similar options (which relate to access over the network) we won't have to modify all these commands yet again. It seems like it'd be a bug for any command to support ssh_cm but not disablePipelining, or vice versa, so we may as well make this explicit in the exports of Darcs.Arguments. > hunk ./src/URL.hs 71 > +pipeliningLimit :: Int > +pipeliningLimit = 100 > + This will cause trouble on configurations that never use it, so I've added an #ifdef to protect it. David _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
