On Wed, Sep 17, 2008 at 2:10 PM, David Roundy <[EMAIL PROTECTED]> wrote: > On Wed, Sep 17, 2008 at 12:50:52PM -0700, Judah Jacobson wrote: >> On Wed, Sep 17, 2008 at 11:47 AM, David Roundy <[EMAIL PROTECTED]> wrote: >> > >> > It would be much better to change the configure test to fail on >> > versions of haskeline older than 0.3. This is easy to do if you made >> > any API change in this release. >> >> Sounds reasonable. There weren't any API changes in 0.3, so I made a >> small addition and released haskeline-0.3.1. See attached (I'm >> resending the EOF/EOT patch unmodified from before). > > Looks good to me, thanks! Applied. I hope this API addition wasn't > purely gratuitous!
Not purely, only partly gratuitous :-) I moved that function from an internal module to an exposed module, which made some of the internal code a little better organized. >> Wed Sep 17 11:01:24 PDT 2008 Judah Jacobson <[EMAIL PROTECTED]> >> * Throw an error when haskeline returns an EOF/EOT. > > One note. This patch adds some trailing whitespace. It's nicer not > to do this. Sorry, I usually try to avoid adding extra whitespace but must have missed it in this case. Thanks, -Judah _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
