Hi, everyone, this is my first attempt at modifying darcs code, I hope everything is acceptable. If not, apologies -- I've only recently become interested in darcs.
This patch solves issue 1041: on a `darcs get', if the URL is invalid, then a directory for it is not created. Cheers, Vlad
Mon Sep 22 20:17:05 EEST 2008 Vlad Dogaru <[EMAIL PROTECTED]> * Get: if URL is invalid, direcotry is not created (#1041) New patches: [Get: if URL is invalid, direcotry is not created (#1041) Vlad Dogaru <[EMAIL PROTECTED]>**20080922171705] hunk ./src/Darcs/Commands/Get.lhs 24 - createDirectory ) + createDirectory, removeDirectory ) hunk ./src/Darcs/Commands/Get.lhs 131 - rfsource <- case rfsource_or_e of Left e -> fail e + rfsource <- case rfsource_or_e of Left e -> do + -- remove the directory if the repo URL is invalid + setCurrentDirectory ".." + removeDirectory mysimplename + fail e Context: [fix bug I introduced into issue1039 test. David Roundy <[EMAIL PROTECTED]>**20080921213043 Ignore-this: 5b3c6476abae6bb050be014555d05bbe ] [Fix hang after a user input error (for example, EOF). Judah Jacobson <[EMAIL PROTECTED]>**20080918163017] [replace consRLSealed with a more general mapFlipped. David Roundy <[EMAIL PROTECTED]>**20080921185241 Ignore-this: c28f73f165254582cba6a14ba6ce93 ] [make issue1039 fix allow small dissimilar repositories. David Roundy <[EMAIL PROTECTED]>**20080921184515 Ignore-this: 918a09df18ef48c649c1bfaa866d6176 ] [revert refactor that breaks type witnesses. David Roundy <[EMAIL PROTECTED]>**20080921182331 Ignore-this: dd692cffc1a238d6726448bacfe9cacc ] [Add '--ignore-unrelated-repos' option to disable unrelated repositories check. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919152631] [Resolve issue1039: detect seemingly unrelated repositories when doing push, pull and send. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919144553] [Refactor in pull_cmd. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919135349 Ignore-this: e26a489a7a53aeaba544ae5ad0006700 ] [Test for issue1039. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919153011] [manual: add an example of record --pipe prompts similar to tag --pipe docs Simon Michael <[EMAIL PROTECTED]>**20080918205353] [user manual corrections regarding what record and tag --pipe prompt for Simon Michael <[EMAIL PROTECTED]>**20080918204500] [clarify the short help for --pipe Simon Michael <[EMAIL PROTECTED]>**20080918193717] [Spaces in Darcs.Arguments. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919150440] [Spaces in Darcs.Commands.Send. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919150139] [Spaces in Darcs.Commands.Pull. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919145812] [Spaces in Darcs.Commands.Push. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919145553] [Print "We have the following patches to send:" only when we really have somthing to send. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080919114229] [Use gmakeisms for prettier output. Trent W. Buck <[EMAIL PROTECTED]>**20080919071358] [TAG 2.0.3pre1 Eric Kow <[EMAIL PROTECTED]>**20080918023645] [Bump version number to 2.0.3pre1. Eric Kow <[EMAIL PROTECTED]>**20080918023634] [Canonize Florent Becker, Matthias Killian, Trent Buck, Thorkil Naur Eric Kow <[EMAIL PROTECTED]>**20080918020453] [ChangeLog entries for darcs 2.0.3pre1 again. Eric Kow <[EMAIL PROTECTED]>**20080918020442] [Re-enable haskeline by default. Require haskeline>=0.3.1 which fixes issue1050. Judah Jacobson <[EMAIL PROTECTED]>**20080917194007] [Throw an error when haskeline returns an EOF/EOT. Judah Jacobson <[EMAIL PROTECTED]>**20080917180124] [Disable more record_editor tests under Windows. Eric Kow <[EMAIL PROTECTED]>**20080917192602 It still appears to be failing under Cygwin. ] [fix changes.pl test (translating to bash) David Roundy <[EMAIL PROTECTED]>**20080917182432 Ignore-this: 5f8bc7e1f9eadc073402a935142281c4 This test made assumptions such as that darcs wouldn't ever add a long comment to its internal representation of changes, which are now broken. ] [hokey fix to allow unit tests to generate random input. David Roundy <[EMAIL PROTECTED]>**20080917170913 Ignore-this: 31e847e82eef741f4c6cc857fd79a245 A nicer fix would be to move namepatch and patchinfo into some sort of random-number monad rather than leaving them in IO and using unsafePerformIO in the example-generation scripts. ] [resolve issue27: add junk to patch identifiers. David Roundy <[EMAIL PROTECTED]>**20080917154657 Ignore-this: b91ab6f6e05e0fda25488fa51653b741 ] [add a couple of tests of unrecord. David Roundy <[EMAIL PROTECTED]>**20080917133738] [add a few (passing) tests of pending handling in obliterate and unrecord. David Roundy <[EMAIL PROTECTED]>**20080917130423] [Use putStrLn for "Cancelled." message. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080916205014] [remove now-unused is_addrmfile and is_addrmdir. David Roundy <[EMAIL PROTECTED]>**20080916173136] [resolve issue1012: it seems to be fixed by the fix for issue709. David Roundy <[EMAIL PROTECTED]>**20080916173116] [resolve issue885: fix patchSetToRepository to work with hashed. David Roundy <[EMAIL PROTECTED]>**20080916173030] [resolve issue709: avoid adding changes to pending in rmpend when possible. David Roundy <[EMAIL PROTECTED]>**20080916173002] [first-stage fix for issue709. David Roundy <[EMAIL PROTECTED]>**20080916170333 Here I fix the bug which leads to a corrupt pending being left, with a rmfile change but no hunk removing the contents. This doesn't fix issue709, since an incorrect pending is left, it's just no longer a corrupt pending (i.e. it's still got the rmfile, but if you record it there's no problem). ] [add new test that we don't do anything when repairing a clean repo. David Roundy <[EMAIL PROTECTED]>**20080916165437] [whitespace change in prepend. David Roundy <[EMAIL PROTECTED]>**20080916160425] [make shell_harness print summary of passing tests when running bugs tests. David Roundy <[EMAIL PROTECTED]>**20080916145820] [trailing whitespace cleanup in Repository.Internal. David Roundy <[EMAIL PROTECTED]>**20080916142112] [tiny refactor in Internal.lhs. David Roundy <[EMAIL PROTECTED]>**20080916155922] [simplify issue965 test (which took quite a while for me to figure out). David Roundy <[EMAIL PROTECTED]>**20080916152028] [Test for issue691. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080916111332] [Make match.pl test understand Windows dates. Eric Kow <[EMAIL PROTECTED]>**20080916011339 Windows does not abbreviate its timezones. ] [Disable some tests that don't work under Windows. Eric Kow <[EMAIL PROTECTED]>**20080916000912] [Translate get.pl test into shell. Eric Kow <[EMAIL PROTECTED]>**20080916000227 The original get.pl uses the Perl Cwd library, which seems not to work for purposes of this test under MSYS. ] [Resolve issue691: distinguish between NoArg and ReqArg in defaults parser. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080915224046] [Move get_default_flag type to definition. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080915220316] [reverse overly-invasive haddocking. David Roundy <[EMAIL PROTECTED]>**20080915110353] [In darcs send if POST fails try sendmail. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914234314] [Grammar in Darcs.Commands.Send. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914232923] [Print "Successfully sent patch bundle to" only when we really sent something. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914232905] [Fix overzealous escaping in haddock. Eric Kow <[EMAIL PROTECTED]>**20080915070926] [Haddock documentation for English.lhs [EMAIL PROTECTED] Docstrings by Eric Kow ] [Haddock documentation for PrintPatch [EMAIL PROTECTED] [Haddock documentation for Flags [EMAIL PROTECTED] [Haddock documentation for Motd [EMAIL PROTECTED] docstring by Eric Kow ] [Haddock string for TheCommands [EMAIL PROTECTED] Docstring by Eric Kow ] [Run testing in temp directories to avoid collosions, fail if DarcsURL header is not found. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914223930] [Use tempfile() UNLINK option to automatically remove temp files at exit. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914223827] [Coding style in upload.cgi. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914223751] [Stop after we found the first DarcsURL: in patch bundle. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914220421] [Spaces in upload.cgi. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080914220324] [Really allow pull.sh test to pass on Windows. Eric Kow <[EMAIL PROTECTED]>**20080914211458 It seems that these redirections cause an openBinaryFile failure under Windows. I do not yet understand why using different names makes a difference, but it could provide an interesting clue. ] [ChangeLog entries for darcs 2.0.3pre1 Eric Kow <[EMAIL PROTECTED]>**20080914094144] [Disable amend-cancelling test under Cygwin. Eric Kow <[EMAIL PROTECTED]>**20080913213039] [Make binary.sh test more portable (avoid copying an exe). Eric Kow <[EMAIL PROTECTED]>**20080913212843 Under Windows, copying the exe file will result in an .exe extension being appended to the filename. This confuses the test. ] [rewrite upload.cgi so it won't need any customization by default. David Roundy <[EMAIL PROTECTED]>**20080913171447 The downside is that it has to do a darcs get --lazy in order to check if the patch can be applied. If you define $target_repo, however, it doesn't need to do this (but then can only accept patches to a single locally-present repo). ] [when _darcs/prefs/post is present, use _darcs/prefs/post for To: header. David Roundy <[EMAIL PROTECTED]>**20080913171025] [sketchy documentation of _darcs/prefs/post David Roundy <[EMAIL PROTECTED]>**20080913115655] [set default upload.cgi to work on darcs-unstable. David Roundy <[EMAIL PROTECTED]>**20080913112227] [Improve upload.cgi. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912230953 - check if patch is valid before sending - use sendmail to send patches or drop to maildir ] [Spaces and punctuation in upload.cgi. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912230827] [fix problem in Darcs.URL refactor pointed out by Eric. David Roundy <[EMAIL PROTECTED]>**20080913104327] [Disable a pull.sh test under Windows. Eric Kow <[EMAIL PROTECTED]>**20080912224027 It relies on darcs not working if we chmod u-r a file. This seems to have little effect in Windows. ] [refactor Darcs.URL to eliminate use of Regexes. David Roundy <[EMAIL PROTECTED]>**20080912173611 The algorithms here are not tricky, and I find this easier to read. ] [change is_file to return false on [EMAIL PROTECTED]: David Roundy <[EMAIL PROTECTED]>**20080912173501] [clean up whitespace. David Roundy <[EMAIL PROTECTED]>**20080912150248] [fix manual for optional arguments. David Roundy <[EMAIL PROTECTED]>**20080912150231] [clean up whitespace. David Roundy <[EMAIL PROTECTED]>**20080912145708] [add test for new --output-auto-name feature. David Roundy <[EMAIL PROTECTED]>**20080912145648] [Spaces in Darcs.Commands.Send module. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912122223] [Make '--output-auto-name' accept optional directory argument. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912120516] [Add DarcsOptAbsPathOption for options with optional path argument. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912112458] [Refactor Darcs.Repository.Prefs.getCaches. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912055204] [Print warning when '--http-pipelining' option is used, but darcs is compiled without HTTP pipelining support. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912054253] [Do not download URL we have speculated before. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912053236] [Spaces and parentheses in URL module. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080912053000] [Coding style in Darcs.Arguments.network_options. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080911140710] [Resolve issue1054: --no-cache option to ignore patch caches. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080911140233] [Remove unused variable from configure.ac. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080911132107] [Comment in configure.ac. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080911115840] [Indentation fixes in configure.ac. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080911115117] [Formating and minor refactoring in URL.urlThread. Dmitry Kurochkin <[EMAIL PROTECTED]>**20080910061227] [insecure printfs - fix the two that I can currently hit Steve Cotton <[EMAIL PROTECTED]>**20080910230659] [TAG this version works. David Roundy <[EMAIL PROTECTED]>**20080910212908] Patch bundle hash: 46babc331482492d2b7334a78d57146ba0c7d7fc
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
