Florent, I've only glanced over the patches, but I'll try to give some good feedback anyway...
Would you please be willing to send in 2 more patches on top of these to address the following: 1) Please haddock more of your newly added functions. 2) Could you add some tests against your new UI? Is the refactor motivated purely by the --lazy-deps option? More explanation of what you're doing here would be nice. Sometimes it's hard to infer your intentions from the code. Thanks! Jason On Mon, Oct 6, 2008 at 11:20 AM, Florent Becker <[EMAIL PROTECTED] > wrote: > Mon Oct 6 19:13:49 CEST 2008 Florent Becker <[EMAIL PROTECTED] > > > * refactor of SelectChanges > > Mon Oct 6 20:12:56 CEST 2008 Florent Becker <[EMAIL PROTECTED] > > > * added a --lazy-deps option > This option means that you don't get asked about patches which do not > match > a --match, but are depended upon by a patch that does. These patches will > get > silently selected. > > _______________________________________________ > darcs-users mailing list > [email protected] > http://lists.osuosl.org/mailman/listinfo/darcs-users > >
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
