I'll be applying this bundle shortly

On Sun, Nov 09, 2008 at 23:01:29 +0100, Petr Rockai wrote:
> >>   The way I have got the recursion versus syncing slurpies backwards is
> >>   actually pretty embarassing.
> >
> > I didn't understand this remark btw...
> Oh, that means:
> 
> >> -            let j = if ((i::Int) + 1 < 100) then i + 1 else 0
> >> -            (ps', s'', restok) <- aaf j s' ps
> >> -            s''' <- if j == 0 then update_slurpy r c opts s''
> >> -                      else return s''

> this code in here would first apply all patches, since the aaf recurses at 
> line
> 3. Then, when we start unwinding from the recursion, for every 100 *returns*,
> we call update_slurpy (line 4) once, writing out the same final slurpy over 
> and
> over again. So this was not saving any memory, and did ridiculous amounts of
> extra work.

I see, thanks!

> > I think we should try to haddock at least the functions we export, and
> > that your comment below would serve just fine:

> Good point. I'll amend if possible, or record a new patch the next time I get
> around to darcs (hopefully early next week).

Please record a new patch, as this bundle is going in
 
-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: pgpWOXy0THlyi.pgp
Description: PGP signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to