On Thu, Nov 13, 2008 at 07:54:40AM +0100, Christian Kellermann wrote:
> * Trent W. Buck <[EMAIL PROTECTED]> [081113 03:04]:
> > Christian Kellermann <[EMAIL PROTECTED]> writes:
> > 
> > > Wed Nov 12 15:59:10 CET 2008  Christian Kellermann <[EMAIL PROTECTED]>
> > >   * make finds more portable
> > >
> > >   This patch changes the way find -exec is used before. OpenBSD
> > >   requires a trailing ';' for work whereas Mac OS X does not like
> > >   that. The solution I choose is to remove the -exec part and replace
> > >   it with xargs.
> > 
> > "-exec {} +" is distinct from "-exec {} \;".  Both are part of POSIX[0].
> > Are you saying the former is not understood by OpenBSD?
> 
> No, that came out wrong. What I am saying is that OpenBSD needs the
> \;. The line should read -exec {} + \; And MacOS X complained about
> that.

How weird that OpenBSD needs that.

> > If that's the case, I would prefer to simply use the latter than to use
> > xargs, because to use xargs safely it is necessary to do the -print0 |
> > xargs -0 dance, and IMO that looks ugly, and in this case we would only
> > save at most a couple of hundred forks.
> 
> agreed.

Yay, consensus.  Would you please amend and re-send your patch to use
{} \; (instead of xargs)?
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to