Hi Gwern, May I ask you to amend and address the issues that Trent pointed out? It'll be handy later on, when for example, one of use decides to do something like a darcs change -p factor
Thanks! On Sun, Nov 16, 2008 at 12:23:20 +1100, Trent W. Buck wrote: > This bundle mostly looks good, and I'm in favour of abstracting the > swathes of boilerplate in tests/. > > Don't forget that tests migrate to and from bugs/, it would be good if > they didn't stop working because ". lib.sh" couldn't find ./lib.sh in > bugs/. > > [EMAIL PROTECTED] writes: > > Sat Nov 15 15:16:08 EST 2008 [EMAIL PROTECTED] > > * +tests/lib.sh: library for test scripts > > This adds a file to the tests directory for storing function definitions. > > This will cut down on silliness like 'not' being defined in 63 different > > scripts - the exact same way. > > Warning: you've supplied a long patch name. A concise patch name is > recommended, with discussion or elaboration in the patch description. > You can use "darcs amend --edit" to change this patch's description. > > > Sat Nov 15 15:18:47 EST 2008 [EMAIL PROTECTED] > > * tests/*.sh: factor out definitions of portable_pwd to lib.sh > > > > Sat Nov 15 15:57:35 EST 2008 [EMAIL PROTECTED] > > * tests/*.sh: factour out ~61 of the 'not' definitions to lib.sh > > Possible typo: did you mean "factor" instead of "factour"? > You can use "darcs amend --edit" to change this patch's description. > > I'm simulating the issue1094 patch name checker :-) > > > [+tests/lib.sh: library for test scripts > > [EMAIL PROTECTED] > > Ignore-this: 639f1e602f31949f93daab6053793127 > > This adds a file to the tests directory for storing function definitions. > > This will cut down on silliness like 'not' being defined in 63 different > > scripts - the exact same way. > > ] addfile ./tests/lib.sh > > hunk ./tests/lib.sh 1 > > - > > +#!/usr/bin/env bash > > This is wrong; shell libraries should not declare shebangs. > Instead, I suggest something "# This is a -*- sh -*- library." > > You will also find that the test harness is running this script because > it ends in ".sh"; this is undesirable. You could either place it in > lib/, or just rename it lib.bash. Or, you could name it something like > 0-common.sh -- so that it sorts to the top in most locales -- and then > have the test harness only run files that start with [a-zA-Z]. > > I also notice that you have "set -ev" in lib.sh, but have not removed > this from scripts. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpOBtbOnblAj.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
