Hi Eric,
* Eric Kow <[EMAIL PROTECTED]> [081116 19:52]:
New patches:
>
> [Conditionally compile out reset_umask on Windows
> Eric Kow <[EMAIL PROTECTED]>**20081116161631] hunk ./src/umask.c 32
> int
> reset_umask(int old_mask)
> {
> +#ifndef WIN32
> umask(old_mask);
> return 1;
> hunk ./src/umask.c 35
> +#else
> + return 0;
> +#endif /* #ifndef WIN32 ... else ... */
> }
I'd rather eliminate calls to reset_umask by redefining umask calls
to a nop than to leave a function call in. You could add a #warn
ing to indicate this on compile time.
> [Add DARCS_TESTING_HOME to shell harness
> Eric Kow <[EMAIL PROTECTED]>**20081116180124
> This enables Petr's workaround for Windows not using $HOME by default
> ] hunk ./Distribution/ShellHarness.hs 49
> env <- getEnvironment
> darcs_path <- get_darcs_path
> let myenv = [("HOME",cwd)
> + ,("DARCS_TESTING_HOME",cwd)
> ,("PWD",cwd)
> ,("EMAIL","tester")
> ,("DARCSEMAIL","tester")
> [Move timestamps test to bugs directory
OK
> Eric Kow <[EMAIL PROTECTED]>**20081116184543
> It never worked on Windows.
> ] move ./tests/time-stamps.sh ./bugs/time-stamps.sh
OK :)
Kind regards,
Christian
--
You may use my gpg key for replies:
pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
pgpOdN0AiwNFm.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
