-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Sat, Nov 15, 2008 at 5:45 PM, Jason Dagit wrote: > On Sat, Nov 15, 2008 at 2:04 PM, Eric Kow wrote: >> Thanks for the patch and the review! >> >> I think I'm willing to apply this, but I'm a bit nervous about losing >> the property that the individual shell tests are self-contained. There >> is also the question of the bugs directory. Maybe we should rename >> lib.sh to lib so that we can keep a copy in bugs. >> >> Generally we like the shell scripts to be very dumb and simple, with >> a relatively small amount of factorisation. I *think* this lib.sh >> idea is reasonable, but I do wonder if there are any potential >> downsides. >> >> So please allow me to flip flop on this overnight, and maybe convince >> me one way or the other :-) > > As I understand it, we like the following qualities in our test suite: > 1) Easy to debug with > 2) Easy to understand > 3) Easy for users to contribute to > 4) Portable > 5) Extensive/catches bugs/etc > > Factorization has the potential to hurt (1), (2) and (3) while helping with > (4). > > Other things we might consider important in a test suite: > 6) Easy to maintain > 7) Attractive -- as in attracts a test suite manager > 8) Domain specific -- contains tools for common darcs testing idioms > > Factorization has the potential to help with each of these. > > Let me coin a term based on (8), let's suppose we have a tool set, > 'the darcs test combinator lbrary' or DTCL. Maybe this is lib.sh, > maybe this is a new language for testing that we write, maybe this is > pure Haskell or maybe it's a set of command-line tools. > > For (3), I think it's quite reasonable that we allow users to submit > tests in shell and then we have someone translate that test to DTCL. > We do this kind of already. The question is how much work is involved > in the translation. > > Currently sh is killing us on (4), and we have things like hspwd, > 'yes' is banned and so on. ... > Thanks! > Jason
It is banned? The README didn't mention anything about that. What else is banned? - -- gwern -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEAREKAAYFAkkhpoAACgkQvpDo5Pfl1oI9uACfXNvcdW7C6KXv9KTixb+gC34k DrMAn3Xv6CwisqSP7vvP11I2z0zeTiQ2 =/jWJ -----END PGP SIGNATURE----- _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
