Hi, I'm going to gratefully apply these, but I thought I might throw in a couple more to go with Christian's review.
Add --in-reply-to flag for send command --------------------------------------- > +in_reply_to = DarcsArgOption [] ["in-reply-to"] InReplyTo "EMAIL" "specify > in-reply-to header" Please submit a type signature for this function in a future patch. I've updated http://wiki.darcs.net/index.html/CodingStyle with a request for top-level type signatures :-) > +\begin{options} > +--in-reply-to > +\end{options} > + > +Use the \verb!--in-reply-to! flag to set the In-Reply-To and References > headers > +of the e-mail to be sent. By default no additional headers are included so > e-mail > +will not be treated as reply by mail readers. Thank-you very much for including user documentation with your patch! > +make_email :: String -> [(String, String)] -> (Maybe Doc) -> Doc -> (Maybe > String) -> Doc > +make_email repodir headers mcontents bundle mfilename = I wonder if this headers field can be used for futher refactoring of the darcs email sending code. Note also that we like to encouarage people to haddock functions too (because we have a bit of an API documentation deficit). Test for darcs send with --in-reply-to option --------------------------------------------- > Pavel Shramov <[EMAIL PROTECTED]>**20081117185534] hunk ./tests/send.sh 29 > > # Test that the --to parameter overrides the default value in the repository > darcs send --author=me -a [EMAIL PROTECTED] --sendmail-command='grep "^To: > [EMAIL PROTECTED]" %<' ../temp2 > +darcs send --author=me -a --in-reply-to=some-thread-id > --sendmail-command='grep "^In-Reply-To: some-thread-id$" %<' ../temp2 > +darcs send --author=me -a --in-reply-to=some-thread-id > --sendmail-command='grep "^References: some-thread-id$" %<' ../temp2 :-) -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpnVWrKJpdLX.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
