On Sat, Nov 15, 2008 at 14:19:08 +0000, Eric Kow wrote: > Could I ask for your review on this one, Petr? Thanks! > Looks like it should be straightforward
Hmm, Petr doesn't seem available, so I'll take over.
Looks good to me, applied!
resolve issue1101: also display cc'ed recipients
------------------------------------------------
> Christian Kellermann <[EMAIL PROTECTED]>**20081115133214
> Ignore-this: 9955a84598aa60e14f5471c02ec0d9b8
> ] hunk ./src/Darcs/Commands/Send.lhs 234
> hunk ./src/Darcs/External.hs 425
> hClose hat
> let ftable = [ ('t',addressOnly t),('c',cc),('f',f),('s',s) ] ++
> ftable'
> r <- execSendmail ftable scmd fn
> - - when (r /= ExitSuccess) $ fail ("failed to send mail to: " ++ t
> + when (r /= ExitSuccess) $ fail ("failed to send mail to: "
> + ++ t ++ cc_list cc
> ++ "\nPerhaps sendmail is not
> configured.")
The new wording "failed to send mail to X and cc'ed Y" sounds a bit
awkward. It may be worth throwing in an extra preposition "failed to
send mail to X and to cc'ed Y", but maybe I should let other people
who are pickier about English chime in
> addfile ./tests/issue1101.sh
> hunk ./tests/issue1101.sh 1
Thanks for the test! It may be useful to give a little hint in the
name, for example tests/issue1101-send-cc.sh
--
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
pgpXSN0RWn5LA.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
