-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On Tue, Aug 19, 2008 at 10:05 AM, David Roundy wrote:
> As I mentioned before when asked about this, I don't think it's a good
> idea. No reason to add the extra complexity for a function that we
> only use to maintain compatibility with old repository formats. The
> best way to keep compatibility with old formats is to not change the
> code.
>
> David
>
> On Tue, Aug 19, 2008 at 03:59:42PM +0100, Eric Kow wrote:
>> Hi David,
>>
>> Another patch you may have missed.
>>
>> ---------- Forwarded message ----------
>> From:
>> Date: 2008/8/9
>> Subject: [darcs-users] UTF8 patch
>> To: [EMAIL PROTECTED], [email protected]
>>
>
>> Sat Aug 9 12:15:10 CDT 2008 Rob Hoelz
>> * Added support for using the utf8-string library if it's available
Eric, now that you're project lead, do you want to reconsider Dr.
Roundy's decision to refuse this patch?
Now that we're cabalized, we could use flags. (Or just make
utf8-string a depended-upon package period, I suppose, which would let
us remove src/UTF8.lhs?)
- --
gwern
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEAREKAAYFAkknLD0ACgkQvpDo5Pfl1oKipgCdECBAOmGZzviH7pRWBvigXJMi
QYoAn0rt0vjrGDwpShV5N9Hw/Se7AAtB
=M7p4
-----END PGP SIGNATURE-----
Sat Aug 9 12:15:10 CDT 2008 Rob Hoelz <[EMAIL PROTECTED]>
* Added support for using the utf8-string library if it's available
New patches:
[Added support for using the utf8-string library if it's available
Rob Hoelz <[EMAIL PROTECTED]>**20080809171510] hunk ./configure.ac 152
+dnl Look for utf8-string
+
+GHC_CHECK_MODULE(Codec.Binary.UTF8.String( encode ), utf8-string, encode undefined,
+ [HAVE_UTF8STRING=True
+ AC_DEFINE([HAVE_UTF8STRING])], [HAVE_UTF8STRING=False])
+
hunk ./src/UTF8.lhs 34
+> {-# OPTIONS_GHC -cpp #-}
hunk ./src/UTF8.lhs 38
+#ifdef HAVE_UTF8STRING
+> import qualified Codec.Binary.UTF8.String (encode)
+> import Data.Word (Word8)
+#else
hunk ./src/UTF8.lhs 45
+#endif
hunk ./src/UTF8.lhs 88
+#ifndef HAVE_UTF8STRING
hunk ./src/UTF8.lhs 106
+#endif
hunk ./src/UTF8.lhs 111
+
hunk ./src/UTF8.lhs 113
+#ifdef HAVE_UTF8STRING
+> encode = Codec.Binary.UTF8.String.encode
+#else
hunk ./src/UTF8.lhs 117
+#endif
hunk ./src/UTF8.lhs 127
+#ifndef HAVE_UTF8STRING
hunk ./src/UTF8.lhs 130
+#endif
hunk ./src/UTF8.lhs 135
+#ifndef HAVE_UTF8STRING
hunk ./src/UTF8.lhs 142
+#endif
hunk ./src/UTF8.lhs 147
+#ifndef HAVE_UTF8STRING
hunk ./src/UTF8.lhs 155
+#endif
hunk ./src/UTF8.lhs 160
+#ifndef HAVE_UTF8STRING
hunk ./src/UTF8.lhs 169
+#endif
Context:
[UF8.lhs: remove unusued functions/imports/docs
[EMAIL PROTECTED]
[Resolve issue974 : do not pass both -optc-g and -opta-g to GHC
Eric Kow <[EMAIL PROTECTED]>**20080807073620]
[make this test more cross-platform
Simon Michael <[EMAIL PROTECTED]>**20080807103433]
[document how to run unit tests
Simon Michael <[EMAIL PROTECTED]>**20080807030416]
[move (most) failing tests to bugs for clean test output
Simon Michael <[EMAIL PROTECTED]>**20080806191336]
[fix an old spelling error
Simon Michael <[EMAIL PROTECTED]>**20080806170432]
[make searching for "test:" in makefile work
Simon Michael <[EMAIL PROTECTED]>**20080805222241]
[run only normal (expected to pass) tests by default
Simon Michael <[EMAIL PROTECTED]>**20080805222108]
[Downplay quantum mechanics link.
Eric Kow <[EMAIL PROTECTED]>**20080806124109
Besides, darcs has far more than 3 users by now.
]
[Make patch theory intro more inviting to math people.
Eric Kow <[EMAIL PROTECTED]>**20080806123411]
[cleanup and slight rewrite of the test docs
Simon Michael <[EMAIL PROTECTED]>**20080806165949]
[make order of running tests consistent
Simon Michael <[EMAIL PROTECTED]>**20080806172123]
[small makefile refactoring: allow just the normal tests to be run, without bugs/*
Simon Michael <[EMAIL PROTECTED]>**20080805203242]
[Rectify dist help
[EMAIL PROTECTED]
Removed the "make dist" suggestion, the manual is a better place for that.
Instead, make clear that it operates on a clean copy of the tree, and
mention the "predist" functionality.
]
[website: explain that darcs 2 is required to get the darcs source.
Simon Michael <[EMAIL PROTECTED]>**20080803181216]
[Canonize Gaetan Lehmann and Daniel Buenzli.
Eric Kow <[EMAIL PROTECTED]>**20080730104357
(for Daniel B, avoid an accent in his name)
]
[configure: check for packages needed with split base.
Eric Kow <[EMAIL PROTECTED]>**20080730103840
Now that all packages must be used explicitly.
]
[fix type witness compile errors specific to ghc 6.8
Jason Dagit <[EMAIL PROTECTED]>**20080722182729]
[avoid import of unused function fromMaybe.
David Roundy <[EMAIL PROTECTED]>**20080729172825]
[configure: suggest regex-compat before text
Eric Kow <[EMAIL PROTECTED]>**20080725095336]
[configure: mention Haskell in 'try installing' suggestion
Eric Kow <[EMAIL PROTECTED]>**20080725095015]
[Typo (Text.Regex)
Eric Kow <[EMAIL PROTECTED]>**20080715121708]
[Use haskeline to have a readline-like behavior when asking something to the user
[EMAIL PROTECTED]
Unlike the implementations using readline or editline packages, this code
code doesn't break the Ctrl-C behavior.
]
[Improve generic rules for English plurals.
Eric Kow <[EMAIL PROTECTED]>**20080604123728]
[add configure check for Network.URI.
David Roundy <[EMAIL PROTECTED]>**20080711011914]
[add -hide-all-packages to default GHCFLAGS.
David Roundy <[EMAIL PROTECTED]>**20080711010952]
[add support for outputting patch numbers in darcs changes.
David Roundy <[EMAIL PROTECTED]>**20080710011211]
[add support for matching single patches by index.
David Roundy <[EMAIL PROTECTED]>**20080710004512]
[add support for matching ranges of patches (counting back from present).
David Roundy <[EMAIL PROTECTED]>**20080710003225]
[Better avoid silly manpage error.
Trent W. Buck <[EMAIL PROTECTED]>**20080704024920
It turned out only initialize's help string used 'quotes', so just
remove them. This makes init's docstring consistent with the others.
]
[Missing period at end of sentence.
Trent W. Buck <[EMAIL PROTECTED]>**20080704024232]
[darcs --overview no longer works, so don't document it.
Trent W. Buck <[EMAIL PROTECTED]>**20080704030804]
[Avoid silly manpage error.
Trent W. Buck <[EMAIL PROTECTED]>**20080703010733
man (nroff) treats an apostrophe in the first column specially,
resulting in a syntax error without this patch.
Ideally, all cases of 'foo' in the manpage (i.e. docstrings) should
become `foo', since man -Tps turns ` and ' into left and right single
quotes respectively.
]
[obliterate whitespace in Darcs.Commands.Get
[EMAIL PROTECTED]
'twas causing lhs/haddock difficulties where a \end{code} wasn't getting recognized.
]
[rm haddock CPP business
[EMAIL PROTECTED]
Try as I might, I can't see any reason to special-case some Haddock CPP logic to deal with some *commented-out guards*, unless CPP magically restores and uncomments the code if Haddock isn't being run.
]
[make pull less verbose when --verbose flag is given.
David Roundy <[EMAIL PROTECTED]>**20080624170035]
[fix makefile to remember to regenerate version information after running configure.
David Roundy <[EMAIL PROTECTED]>**20080624170001]
[TAG 2.0.2
David Roundy <[EMAIL PROTECTED]>**20080624012041]
Patch bundle hash:
3a2cc4988613b9b14514df7baf79440e050f345b_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
