-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Fri, Dec 19, 2008 at 11:20 AM, Neil Mitchell wrote: > Hi Gwern, > >>> when foo $ do stuff >>> moreStuff >>> lastOfTheStuff >> >> (when packages up the 'if foo then bar else return ()' pattern.) > > Fantastic idea, and really trival to add. It now finds 9 examples such as: > > Darcs/Commands/Annotate.lhs:327:1: Use when > Found: > if wheni `elem` old_pis then > do putAnn $ text "Following line added by " <> showPatchInfo wheni > putLine ' ' l > else return () > > Why not: > when (wheni `elem` old_pis) $ > (do putAnn $ text "Following line added by " <> showPatchInfo wheni > putLine ' ' l)
Hm, I'm not sure I'd put parentheses around it, but whatever. So hlint is indeed easily updated? Then I guess I'll send you further bad idioms as I find them. > I have fixed most of the issues reported on this list, and raised bugs > for the remaining ones. I've implemented an "ignore" feature, > documented it. I also included a section in a manual on how a user can > add their own hints such as above. I've also renamed the project to > "hlint" as suggested. > > Thanks very much for all the helpful feedback that everyone has given. > I'll have a version released tomorrow with any luck! > > Thanks > > Neil Great. hlint really is a better name - it instantly tells one what it does (everyone knows what 'lint' does), and doesn't conflict with current names (eg. DrHylo). - -- gwern -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEAREKAAYFAklLzWsACgkQvpDo5Pfl1oL3zACfUXRCmOtJHz1ao436WgYrG9fl alsAnjAV4njWRwL0YgyZxW3SX5N+LWbo =rm8m -----END PGP SIGNATURE----- _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
