Le Wednesday 07 January 2009 15:22:06 Eric Kow, Eric Kow a écrit : > Content-Description: A darcs patch for your repository! > > > + putStrLn $ varname ++ " =\"" ++ concatMap escape ls ++ "\"" > > + where > > + escape '\n' = "\\n\\\n\\" > > + escape '"' = "\\\"" > > + escape '\\' = "\\\\" > > + escape c = [c] > > Hmm, any idea if there is a way we can make the compilation faster while > still keeping things easy to understand? All those backslashes confuse > me, although I (think I) get the idea that you're trying to > doubly-protect them, once for this code and once for the generated code. > > I'm perfectly willing to apply this, of course, though I would have > found it easier to review if you had not included the needless > whitespace changes. Previously, I had requested in general that > whitespace changes be "snuck in", but only to lines that you were > already touching anyway. Otherwise, the principle of keeping patches > fairly minimal is quite a nice one. :-D > > Just let me know what to do here. Thanks!
I'm not too keen on redoing that patch just for the sake of cleanliness. If i find a more elegant way to get rid of the \s, i'll roll it back and make a clean patch, but don't count on it. Florent _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
