On Wed, Apr 22, 2009 at 12:23:09 +1000, Trent W. Buck wrote: > >> <[email protected]> > >> * Darcs.Commands.Changes: do not do read_repo twice. > > > > We already noticed this during the sprint, but concluded > > that it's called twice to prevent a memory leak. > > If that's the case, someone should add a comment to that effect, so that > the next person to hack on this code will "get it".
Yep! Definitely good to use comments for things which aren't immediately obvious. Would you mind doing this, Dmitry? -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpnFCtQ6Tvu9.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
