On Sat, May 09, 2009 at 21:19:48 +0200, Salvatore Insalaco wrote: > Windows path handling is still not optimal, but to fix it we should > probably make bold choices (like stopping to convert everyting to > "posix-like" format, as some kind of Windows path have no Posix > equivalent); this patch at least avoid an infinite loop inside darcs.
Sigh :-) Hopefully we can one day spin off our RepoPath and our path-fixing code to be a standalone module. > Sat May 9 20:36:06 CEST 2009 Salvatore Insalaco <[email protected]> > * Resolve issue1351: fix repository path handling on Windows. > > ioAbsolute is supposing that takeDirectory will eventually lead to > an existing directory. This is true on Posix, where it will lead to > "/", but not on Windows, where it could lead to a non-existing unit or > an UNC reference to a non-existing server. > This patch fixes this assumption, avoiding an infinite recursion. This looks good to me. Could I be annoying and ask you to amend --edit that patch, wrapping that description at 72 characters? > Sat May 9 20:57:02 CEST 2009 Salvatore Insalaco <[email protected]> > * Remove unused function: Darcs.Patch.Prim.applyBinary I've applied this one, thanks! -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgp6eVUBQ3cCf.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
