On Thu, Jun 11, 2009 at 23:30:46 +0200, Petr Rockai wrote:
> - we need writeable mmap for hashed-storage, and bytestring-mmap doesn't
> - mmap, unlike bytestring-mmap, works on win32
> - it's probably better to unify on a single package and API instead of two

Just one quick comment

Use the mmap package instead of bytestring-mmap.
------------------------------------------------
>    if flag(mmap) && !os(windows)
> -    build-depends:    bytestring-mmap >= 0.2
> +    build-depends:    mmap >= 0.2
>      cpp-options:      -DHAVE_MMAP

Can we also relax the !os(windows) restriction, then?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: pgpnTIAOB0viV.pgp
Description: PGP signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to