Eric Kow <[email protected]> writes: > One small complaint: I don't mean to be too picky about process here, > but I think it's a good idea for patches to flow from mainline into the > release branches, rather than the other way around. Don't get me wrong, > I understand that it makes sense for things like Cabal tweaks and > ChangeLog entries and tags to just get done and sent later for > expediency. In particular, I would have been a lot happier to see > Ganesh's zlib patches (like all other patches) go through a public > review before they got applied to a darcs we expect people to use. [*]
[snip] > [*] I think you may have mentioned off hand that you'll do a review of > these before applying them, in which case thanks! Just don't > forget to tell us (esp Ganesh) about it :-) I did a cursory review. It's not a full review though, so you probably still want to have the patches fully reviewed. My reasoning is that this is already a public darcs branch, so we cannot amend the patches anyway. If we record new patches to address review concerns, they can be easily pulled into the release branch as well. The priority for the beta was to get coverage for the features we want in final. Delaying the patches for another 15 days till beta 2 would have reduced the coverage they get considerably. That's why I short-circuited on the release branch. Everyone has known the release schedule at least 3 or 4 weeks in advance and I can't delay things indefinitely (especially if we publicly claim that we are on time-based scheduling). The net result is that although there was reduced review coverage for a beta release, the zlib crc patches are quite safe (in my opinion), and this is a beta release: inconveniences are acceptable (if the warning code goes wrong, for example). The increased testing coverage is well worth it, in my experience. As for pulling into mainline: I suppose you are free to wait till full review happens. Eventually, we will get into the state that release branch is a subset of the mainline -- I am not in a hurry for that. I am in a hurry to get the beta out to more people and get some field-testing. Yours, Petr. -- Petr Ročkai | http://web.mornfall.net A physicist is an atom's way of knowing about atoms. (George Wald) _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
