Mon Sep 14 21:24:17 BST 2009 Ganesh Sittampalam <[email protected]> * add several more darcs-hs review points
New patches:
[add several more darcs-hs review points Ganesh Sittampalam <[email protected]>**20090914202417 Ignore-this: 231ddf3fca3d2aaed41a28e4bbb9ff03 ] hunk ./Review/DarcsHS.page 244 See http://lists.osuosl.org/pipermail/darcs-users/2009-September/021352.html +11. Hashed filename format + + Ganesh (14/09/09): We've discussed the removal of sizes from the filename format before, but I'm still not entirely clear on why they were introduced in the + first place. Do you know why, and could you write a brief justification for their removal? My general impression is that size+hash is generally considered + more robust than hash alone, but that might be wrong/outdated. The ten digit limit is certainly a bit silly. + +12. Unsorted variants of ``get_unrecorded`` gone + + Ganesh (14/09/09): The _unsorted variants of get_unrecorded_* (now unrecordedChanges) have gone. They used to omit the sort_coalesceFL call where it wasn't + needed. Have you checked on the performance implications? + +13. How do you call ``unrecordedChanges`` to read all changes? + + Ganesh (14/09/09): This is something that the old get_unrecorded_* interface used to do if you passed in an empty list, but now empty list means "just read + pending". + +14. Please add some haddock to unrecordedChanges + + Ganesh (14/09/09): This is a pretty crucial function in the new world. + +15. ``invalidateIndex`` safety + + Ganesh (14/09/09): It's quite dangerous to have to call this from each relevant command. Can't the repository code track whether it's needed? + +16. ``treeDiff`` should be called ``unsafeTreeDiff`` + + Ganesh (14/09/09): It's just as unsafe with respect to witnesses as the old one was - though perhaps we should use another prefix to indicate witness unsafety + as opposed to segfault unsafety. + Addressed --------- Context: [Link to my notes on bug-tracker vs. mailing list. Eric Kow <[email protected]>**20090914141935 Ignore-this: 62486815c2601b234b985911dedd6ad4 ] [Add Ganesh (and alphabetical order on everybody) Eric Kow <[email protected]>**20090914131359 Ignore-this: 11e4a63828d0ab13d38734cb1dd58b0e ] [Rah-rah, Darcs 2.4! Eric Kow <[email protected]>**20090914114216 Ignore-this: d3ed30998692bb47f8a3d6d702f33d3a ] [Resolve issue1244: mention .ssh/environment on troubleshooting page. Trent W. Buck <[email protected]>**20090914032215 Ignore-this: f727477ac452e4ad278913c896a4c34d ] [Brutally focus on hashed-storage for Darcs 2.4. Eric Kow <[email protected]>**20090914112329 Ignore-this: acc8c8ce0ae339695e983ea79f15253a ] [describe what is the problem with my patch Kamil <[email protected]>**20090913213559 Ignore-this: 1e058f8f3bb124d3aa99d019f3ed4084 ] [add performance issue raised by lispy GaneshSittampalam <[email protected]>**20090913205951 Ignore-this: 9acae72d267c71659cc04aa45f137f3d ] [DarcsHS review point GaneshSittampalam <[email protected]>**20090913203044 Ignore-this: 8664cc95e8d49bf9f2a9157ebdef90fc ] [I meant darcs not repo Kamil <[email protected]>**20090913173701 Ignore-this: 5034feb76b8c4bd20d0cd1acc7d1d6ed ] [note about orphan patches GaneshSittampalam <[email protected]>**20090913160057 Ignore-this: d19a2018bbacf991f51a9a59fe11f240 ] [ok, that will work now I hope (preview still does not work :P) Kamil <[email protected]>**20090913084842 Ignore-this: ba0c817953dd89eeb6c5399b2e8962ad ] [trying if pre works (preview functionality is broken at the moment :P) Kamil <[email protected]>**20090913084318 Ignore-this: 52bf3a3afea1a91157a8795f910f6701 ] [issue 1406: fill in with content from email conversations Kamil <[email protected]>**20090913084209 Ignore-this: 4c81251e5c1eb5eb47ef113a16a37613 ] [more kowey <>**20090913080109 Ignore-this: c12aa765c09fefef1ae7033858c5c94 ] [darcsit assumes internal links are relative to current page, not to wiki kowey <>**20090913075530 Ignore-this: e98145b63d2ec7b2bc44ada002cff0e6 ] [add link to issue1325 kowey <>**20090913075423 Ignore-this: c31917bbcb8e7ffc5bda26bfc1de9314 ] [syntax tweak kowey <>**20090913073716 Ignore-this: fa671ec7b2cb0bebcc57e683eacc51a8 ] [Create a review page for issue1406. Eric Kow <[email protected]>**20090913073112 Ignore-this: 6ebd9a9c8bfba6a8adbaa0fa862d350c ] [checkpoints gone in Darcs 2.4 kowey <>**20090913064058 Ignore-this: a45a185bd869c818db682b940f535644 ] [whoops, wrong wiki syntax kowey <>**20090912211053 Ignore-this: 58d98a98eb41e9458b5aeb675810f8ef ] [wibble kowey <>**20090912210720 Ignore-this: 1f0332068ad7db4d4f89b3ac272ac467 ] [link to checkpoints kowey <>**20090912210647 Ignore-this: cfc0a8c9bef18c72423e3e97fea44aa4 ] [some notes on checkpoints kowey <>**20090912210530 Ignore-this: 88e40089eec74f9b698c08750fdb4c7c ] [More DarcsHS review updates. Petr Rockai <[email protected]>**20090912203934 Ignore-this: d40cbb1678a10f1195090c29d02e92a7 ] [Provide one-stop documentation for very clueful newbies. Trent W. Buck <[email protected]>**20090911110215 Ignore-this: b0d395dbc5947ab87266d60dcc9394ba ] [A number of updates on DarcsHS review + cleanup deferred/addressed issues. Petr Rockai <[email protected]>**20090912105537 Ignore-this: d4856b40569b300c9dae621f6c34e535 ] [Clarify how to get MSYS. Petr Rockai <[email protected]>**20090831155319 Ignore-this: 825d50b11e586ad8cdcf5ac180a98853 ] [need-action vs need-implementation, waiting-for vs deferred kowey <>**20090911193521 Ignore-this: 12a15e6e38ad4309b92daee9d1db7ef8 ] [try to clarify waiting-for vs need-action (argh, needing to clarify is a bad bad sign; too complicated?) kowey <>**20090911193053 Ignore-this: 9f651aedf7c5af480567132f6c52e705 ] [We're a bit more policy driven than I thought. Eric Kow <[email protected]>**20090909152412 Ignore-this: 6f104d42fcc010f2b69ed1b50c2ce299 ] [Small policy page. Eric Kow <[email protected]>**20090909150737 Ignore-this: c3cdb8f1bbdbaa7ff83ac7146a704896 ] [Fix a couple more broken links. Eric Kow <[email protected]>**20090909145833 Ignore-this: ffb63aea5a5d6fd87864089a39032329 ] [Fix some broken links from Development tidy up. Eric Kow <[email protected]>**20090909145521 Ignore-this: e3b38b17f68390c171b9c2dfd1c0b7b0 If only we had redirects. ] [topic wibble kowey <>**20090907213751 Ignore-this: 76a79cfe67ea27b2cf760ee1a7d7568e ] [An important fourth case. Eric Kow <[email protected]>**20090906204011 Ignore-this: 7a2e7cdf327cfa24c09e75f6a3ca09bd ] [Explain bug in get_extra commuting patch. Eric Kow <[email protected]>**20090906203731 Ignore-this: 49c9f059db7c706d5a0e0900942a1c8e As far as my limited understanding allows anyway. ] [Define commutation. Eric Kow <[email protected]>**20090906082503 Ignore-this: 968746f37ba71b144aab41b575ea7ee0 I'm sure it's a lousy definition, but I think having a lousy one beats having 'commute': TODO be the first entry of the glossary. ] [Define hunk and point out git/primpatch confusion. Eric Kow <[email protected]>**20090906074723 Ignore-this: 45134de78c28787c189aa0a71bc9dad4 ] [Use RST definitions and alphabetise. Eric Kow <[email protected]>**20090906074028 Ignore-this: 544a8192a0a34f35dcc1c29206ac4631 ] [Rearrange performance stuff for troubleshooting. Eric Kow <[email protected]>**20090905132602 Ignore-this: db59eee8254db68b771b02183896c556 ] [link to issue80 re out of memory bug kowey <>**20090904121741 Ignore-this: a377b819eab1d9b30734601b7570e9c4 ] [faq tip for smaller patch bundles kowey <>**20090904121558 Ignore-this: e97014761bef82c39a7d9f53e74b3d96 ] [darcs replace tips - only kowey <>**20090903101613 Ignore-this: 872c70b561a2e1d32537329e4a65faeb ] [twb is our doc manager (he said it himself!) kowey <>**20090903065357 Ignore-this: 2e334be89e43c2f825b0de949c8506b3 ] [the new failing foo convention kowey <>**20090902203936 Ignore-this: e47696ca921788253748d58ce4400d28 ] [link to multiple private key guide dagit <[email protected]>**20090901062135 Ignore-this: 79de5d20e8ff41bec6d439b392801352 ] [updated link to myself dagit <[email protected]>**20090901061904 Ignore-this: bb8505b7238a59eb53c1ddf9228e4d66 ] [Created People page for Jason Dagit (I wish this description field auto populated) dagit <[email protected]>**20090901061810 Ignore-this: f5cd169d1e2f4389343c43336356d8ee ] [added myself to review team dagit <[email protected]>**20090901061531 Ignore-this: 2a3462b7905672556e3fdb322206005d ] [Fix link. Petr Rockai <[email protected]>**20090831155207 Ignore-this: b8651367885114752cc9a9fa6d541476 ] [Clean up and update BuildingUnderWindows. Petr Rockai <[email protected]>**20090831155022 Ignore-this: ace9506fa8dca1e9abeff652ab0dc597 ] [Fix link. Petr Rockai <[email protected]>**20090831153046 Ignore-this: cc52c1285492596e2c1420ef350f5945 ] [Update TODO. Petr Rockai <[email protected]>**20090831153003 Ignore-this: 1e0bcb00fa21f66cc8605692eef1e925 ] [Minor formatting in Development/GettingStarted.page. Petr Rockai <[email protected]>**20090831152913 Ignore-this: e86ce7b6b3e580d9392b73d2bf0f816d ] [Reorganise Development, move Developer* pages to Development/ and clean up refs. Petr Rockai <[email protected]>**20090831152802 Ignore-this: 2c3fe9791a29373f9cf856d33451d04d ] [Update buildmaster URI. Petr Rockai <[email protected]>**20090831140430 Ignore-this: 98ff733d121721cdb7a5c7abd6ad8350 ] [busy dmitry kowey <>**20090831091958 Ignore-this: 5883148bf5e4f0504013b2b7edf57a3f ] [Fix ReST. mornfall <[email protected]>**20090830185253 Ignore-this: 873d07db4854351fb79a69e482421e4e ] [Add a basic Development/PatchReview page. Petr Rockai <[email protected]>**20090830185045 Ignore-this: ce5f975533d1449b0031b6cb9b84a10d ] [Short note about Ganesh's branch. Petr Rockai <[email protected]>**20090830130131 Ignore-this: 3c0b2d9cd8ac350b785b077d94fccb56 ] [fixed formatting of literal blocks (intention would be also nice, though) tda <[email protected]>**20090830120800 Ignore-this: e6751ce723b57458f8eda0c24bf6ca17 ] [I've made a branch abstracting out darcs-specific stuff Ganesh Sittampalam <[email protected]>**20090830093538 Ignore-this: 7ab1e621936be35d180b4115c7d05b00 ] [Crypt is inside src, indent correctly Kamil <[email protected]>**20090828183152 Ignore-this: e47a3802cb488f454076fb74aa45f195 ] [TAG 2009-08-28 (autotag) [email protected]**20090828103009 Ignore-this: 3d59d2305bf8bba773bb59f02b1614a4 ] Patch bundle hash: 7d977dd57203fc21d8c814534f7e990d3d859140
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
