Tue Nov 17 13:48:40 CET 2009 Florent Becker <[email protected]> * detail review process for outsiders
New patches:
[detail review process for outsiders Florent Becker <[email protected]>**20091117124840 Ignore-this: 8fddf493fc768503ba33a8af29d76771 ] hunk ./Development/PatchReview.page 29 necessary to get it back to green if anything breaks (but don't panic, anyway). For help setting up your ssh keys, try `this guide <http://www.karan.org/blog/index.php/2009/08/25/multiple-ssh-private-keys>`_, which explains how to manage multiple key identities per host. + +Helping out review +------------------ + +If you are not (yetâ¦) a member of the review team you can still help doing patch reviews. First, you need to find patches to review. + +- For this, go to the `bugtracker <http://bugs.darcs.net>`_, get an account and login. Then, look in the `open patches <http://bugs.darcs.net/patch?status=-1,1,2,3,13,14&@sort=-activity&@dispname=Show%20Unassigned&@filter=status&@group=status&@columns=id,creation,title,status,assignedto&@pagesize=50&@startwith=0>`_ section for unassigned patches which need review. + +- Pick your favorite. First, assign it to yourself and set the status to review-in-progress. Then do the review proper: test and read the patches; reply to the patch as you would reply to a usenet message, interleaving your comments with the body of the patch. Then you need to send the review back to the list and patch-tracker. Either reply via the patch-tracker's web interface, or reply to the mailing list message. + + - If you think the patch should be applied, set the status to **accepted** (if you reply by mail, add [status=accepted] to the subject-line), and notify in the body that you have not applied yet. + - If you think the patch is inappropriate for darcs in a definitive way, set the status to **rejected**. + - If some thing should be changed before application, set the status to **amend-requested**. Context: [RST tweak kowey <>**20091116211441 Ignore-this: e2e79d54b77da6845fb9badc7229242b ] [stub for ZuriHac sprint kowey <>**20091116202416 Ignore-this: 36a8cac06429a950a33588fd12ecd485 ] [update main sprint page with link to 2010-03 kowey <>**20091116202221 Ignore-this: 6456e00e8823d5fe5d5fb03cf8317d16 ] [add more details dagit <[email protected]>**20091116011024 Ignore-this: 4af02b9f124312221fe60e6e70dc8852 ] [add more steps dagit <[email protected]>**20091116003030 Ignore-this: 8d5137613a3e5c010f2e3f243a8e1d1c ] [add function names dagit <[email protected]>**20091116002417 Ignore-this: c1972f3560613fff0afcf22df5f1d75f ] [Add all demands for 2.4 release to roadmap ReinierLamers <[email protected]>**20091115181934 Ignore-this: 92031d2448b1dff3971091599ecde086 ] [making it better kowey <>**20091115164424 Ignore-this: 958f4c10048c3a6bc577e3fe0b165c62 ] [update msmtprc instructions david <>**20091115162012 Ignore-this: 36ffab1959d3e2da622fdea771adf162 ] [note Windows meeting kowey <>**20091115160152 Ignore-this: cea0d422c342ef475396e061076b19f8 ] [Add developer FAQ for type witnesses. Eric Kow <[email protected]>**20091115152430 Ignore-this: af38fe4b3c8454e04bf62e62dfcd4e62 ] [tweak instructions for darcs setup kowey <>**20091115143400 Ignore-this: a680be6822dc1ce1e99cf02349d16f2f ] [update link to issue david <>**20091115142654 Ignore-this: 5978c26826faa324d80e954f575fda7c ] [another probablyeasy bug kowey <>**20091115095028 Ignore-this: 36bb956e04f1bcba9fb091d36e44ca67 ] [tidy up kowey <>**20091115094851 Ignore-this: c4036d0b8412d7c6c79dd866fe150321 ] [wibble kowey <>**20091115094659 Ignore-this: ededd6f5e2cd1f576c52d7cb0ddc3db3 ] [windows meeting results kowey <>**20091115094550 Ignore-this: 5ccb23174c64898650cb03c137d6f70c ] [Taken a bug volothamp <[email protected]>**20091115085349 Ignore-this: 6ce75bd45eb377d1bf6c8b3f849ebd6e ] [woo, windows! kowey <>**20091115084620 Ignore-this: be9c2a609ceb37a704876b4d0bc0bff9 ] [re-arrange probablyeasy todo kowey <>**20091115084546 Ignore-this: ba67e04ce0b82714eed1f8935e59cf8d ] [i'll take issue1122 david <>**20091115084013 Ignore-this: 6410fae753f656c4503b87d84961d30f ] [windows meeting notes kowey <>**20091115083455 Ignore-this: fb416dce4b2ebf681e2070d020d47945 ] [add more items dagit <[email protected]>**20091114191924 Ignore-this: 9ed3482be660a0bb3374371ab57dbb3 ] [saving intermediate edits dagit <[email protected]>**20091114190932 Ignore-this: 959dadf330abe5555afe69be40037bb9 ] [Update status of issue1500 tommd <>**20091114185823 Ignore-this: 78b5dfb4725c04b19cb0bb84cf8b48d6 ] [Update status of issue223 tommd <>**20091114185327 Ignore-this: 28a06bb595acef2a91974c1186c92f14 ] [add page about speciication of record dagit <[email protected]>**20091114173808 Ignore-this: 924e236c0090802b68455cff63daa150 ] [add link to not-yet written page about how record works dagit <[email protected]>**20091114173601 Ignore-this: cd3e3dbd8e6c476da039e3573febbde2 ] [progress kowey <>**20091114173155 Ignore-this: c76bdce3d71f4c2dc474872ccff599fa ] [Some more stuff in darcs/hs integration has been addressed. Petr Rockai <[email protected]>**20091114145842 Ignore-this: c02d15f022cbdcb37b74f07b73ec05db ] [some notes kowey <>**20091114145143 Ignore-this: 7b98588ce2f7d7c4549d4eaa83477b37 ] [added food opportunities tdanecker <[email protected]>**20091114114446 Ignore-this: b503a7ca647989b31fb3652af3933be ] [more links kowey <>**20091114101417 Ignore-this: b0d7b77936dddd76725b4b72fe98805 ] [Getting started: Add edit-description to defaults visq <>**20091114093750 Ignore-this: a201320382bdfcad982a9a8958e01636 ] [add myself as a mentor ReinierLamers <[email protected]>**20091114092734 Ignore-this: 908f6310e6d2405d465aca8fcb9438a1 ] [msmtp example kowey <>**20091114092534 Ignore-this: c032e9abc725f6682aee2808da63b256 ] [wibble kowey <>**20091114092144 Ignore-this: a477a47aba16cd02ccbe691b4f40aa4a ] [for details kowey <>**20091114092122 Ignore-this: a2fdae78e71c41a4fcfe3b85136d9be7 ] [whitespace kowey <>**20091114092012 Ignore-this: cbbef88545e9eec80394cd48e5e99a66 ] [more instructions kowey <>**20091114091943 Ignore-this: 76d592c2fdd67a8103706961f3661d3b ] [wibble kowey <>**20091114091525 Ignore-this: c431fefce5c5b252af3e364f362f999d ] [more getting started kowey <>**20091114091506 Ignore-this: bb053fac7a61368fdfa25d477b3bafe9 ] [add hashed storage info kowey <>**20091114091207 Ignore-this: 1643f71c0c78efb05a2540d2d7aff2dc ] [add some stuff kowey <>**20091114091121 Ignore-this: 33e862976f730a3f95c88fc0171aa105 ] [add bug entries for ProbablyEasy kowey <>**20091114085647 Ignore-this: 9ca0d58785173b33c5a89860ea5a4d1f ] [TAG 2009-11-14 (autotag) [email protected]**20091114083835 Ignore-this: 6f596369823d906b7e35f79fc7ba2030 ] Patch bundle hash: dcfa97efa01617f364ccc9dcb2f1da416efe390b
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
