Ganesh Sittampalam <[email protected]> added the comment: I've now run the tests on GHC 6.8.3, 6.10.4 and 6.12.1, and also checked the changes more carefully and concluded that I'm happy to submit the initial version I sent.
I think the only place where I change semantics is in a few places in Darcs.Lock, where the code used to catch any kind of exception and now just catches IO exceptions. Because the handlers are wrapped around an IO operation, I think this is appropriate - in a couple of places the handler is being used to annotate the error message with information on what file failed, and in another place it's being used to trigger a retry. I don't think it makes sense to do either of these things for non-IO errors. ---------- status: amend-in-progress -> needs-review __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch119> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
