Hi, davidm <[email protected]> writes: > Sun Jan 10 21:18:36 CET 2010 David Markvica <[email protected]> > * remove the hardcoded string "_darcs" in some places and replace it with > the global darcsdir I think there is certain ambivalence about the usefulness of the darcsdir global. But let's put that aside (I don't particularly care.)
> Sun Jan 10 22:29:32 CET 2010 David Markvica <[email protected]> > * Resolve issue1726: Files with _darcs prefix are always boring > hunk ./src/Darcs/Repository/Prefs.lhs 240 > isDarcsdir "" = True > isDarcsdir ".." = True > isDarcsdir "../" = True > -isDarcsdir fp = darcsdir `isPrefixOf` fp > +isDarcsdir fp = darcsdir == fp I don't think this is correct. I'd say: isDarcsdir "_darcs" = True isDarcsdir fp = "_darcs/" `isPrefixOf` fp Another option would be to use System.FilePath to break up fp and check that (take 1 $ map dropTrailingPathSeparator $ splitPath fp) == ["_darcs"] -- this is probably safest, although most elaborate. Yours, Petr. _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
