Eric Kow <ko...@darcs.net> writes:
> On Wed, May 05, 2010 at 01:56:52 +0000, Dino Morelli wrote:
>> Tue May 4 18:22:26 EDT 2010 Dino Morelli <d...@ui3.info>
>> * Accept issue1232: darcs convert fails if missing _darcs/prefs/prefs in
>> src
>>
>> Tue May 4 21:39:46 EDT 2010 Dino Morelli <d...@ui3.info>
>> * Resolve issue 1232: darcs convert fails if missing _darcs/prefs/prefs
>>
>> In the earlier fix for this issue, did not consider the possibility that
>> the prefs file may not be present in the source repo.
>
>> +# Check that the new repo is d2
>> +[ -e S/_darcs/hashed_inventory ] || exit 1
>
> You don't actually need to || exit 1 here
> I don't think.
Ack, you don't need that || exit 1, and it's also more customary to write
test -e ...
instead of
[ -e
(or, test -f, even)
When you amend the patches as Eric asked (i.e. avoid Accept
issue1232/Resolve issue1232 I think this should go in).
Yours,
Petr.
_______________________________________________
darcs-users mailing list
darcs-users@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-users
