Hello,
On 05/28/2010 10:50 PM, Eric Kow wrote:
If I understand correctly, you're trying different ssh commands (plink
-P, ssh -p, etc) in succession and returning the first one which
succeeds.
It looks like you need to feed it arguments (something to connect to?)
for the test to work. Is there a way to just call it without trying to
make a connection? If not, what if the test fails legitimately (eg.
can't connect to server). Also, could the test fail "legitimately"?
It doesn't assume the ssh command implementation using the name but
using the response on the `challenge request` (e.g. run the command with
the -V option).
See this patch which incorporates that functionality into darcs (Ssh.hs):
http://bugs.darcs.net/patch254
What if the user renames their plink to ssh?
It uses the output of the command with -V option and no command name itself.
Also, how would this interact with DARCS_SSH (in your opinion?)
It uses the command part of the $DARCS_SSH.
You may be particularly interested in http://bugs.darcs.net/issue1576
which if I understand correctly, would naturally subsume this work.
Yes. This looks much more reasonable than some auto-detection.
Anyway, layer behind the various command options for putty
or ssh has to be unified across the darcs code.
Also, you may be interested to note that I've heard one report that MSYS
OpenSSH actually works just fine and dandy with Darcs under the DOS
command line (and unless Salvatore chimes in), we could perhaps start
steering users towards that instead?
I'm not sure what other problems are here related to need within Darcs
support more than one SSH implementation. If the problem is
passing different options to different commands I do not feel it like a
good reason for pushing people into some particular SSH implementation.
This would side-step some other issues, particularly
http://bugs.darcs.net/issue845
Is this just stderr vs stdour difference?
Within the discussion there are concerns about the unnecessary messages
on stderr.
Why we want suppress any message from ssh command executed by the darcs ?
I would like to see example of the noisy message there is talked about :)
Anyway, we can pass "-batch" flag for plink (included in patch) at least
for "hang" prevention.
_______________________________________________
darcs-users mailing list
darcs-users@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-users
