And finishing the review for the remaining four patches:
All looks fine, except for: > [Drop the "test" cabal flag and build darcs-test unconditionally. ... > - if !flag(test) > - buildable: False > - else > - buildable: True > - build-depends: base < 5, > - extensible-exceptions >= 0.1 && < 0.2, > - regex-compat >= 0.71 && < 0.94, > - mtl >= 1.0 && < 1.2, > - parsec >= 2.0 && < 3.1, > - html == 1.0.*, > - filepath == 1.1.*, > - QuickCheck >= 2.1.0.0, > - HUnit >= 1.0, > - cmdlib >= 0.2.1 && < 0.3, > - shellish >= 0.1.1 && < 0.2, > - test-framework >= 0.2.2, > - test-framework-hunit >= 0.2.2, > - test-framework-quickcheck2 >= 0.2.2 > + buildable: True > + build-depends: base < 5, > + extensible-exceptions >= 0.1 && < 0.2, > + regex-compat >= 0.71 && < 0.94, > + mtl >= 1.0 && < 1.2, > + parsec >= 2.0 && < 3.1, > + html == 1.0.*, > + filepath == 1.1.*, > + QuickCheck >= 2.1.0.0, > + HUnit >= 1.0, > + cmdlib >= 0.2.1 && < 0.3, > + shellish >= 0.1.1 && < 0.2, > + test-framework >= 0.2.2, > + test-framework-hunit >= 0.2.2, > + test-framework-quickcheck2 >= 0.2.2 This seems nice but also magnifies the concerns in my previous message, since these dependencies are now darcs's as well. _______________________________________________ darcs-users mailing list darcs-users@darcs.net http://lists.osuosl.org/mailman/listinfo/darcs-users
