Am Donnerstag, 26. November 2015, 22:48:26 schrieb Caio S. Souza: > Hello!
Hi. > I'm almost done implementing this feature, but I have two questions. > 1) I had to add one entry to the struct dt_iop_channelmixer_params_t > to store where the correction must be applied. Should I increment the > version in the DT_MODULE_INTROSPECTION macro? Yes. > 2) The final outputs of red, green, blue and gray channels are clipped > to avoid out of range values. But the clip is applied only partially > for the hue, lightness and saturation (on both CPU and opencl > versions). Was it on purpose or is it a bug? I haven't looked at the code, but in general we should try to avoid clipping wherever possible. > Cheers Tobias [...]
signature.asc
Description: This is a digitally signed message part.
