Hi Torsten, Thanks for the information. One of the things that has confused me is that the lens menu gets filled with multiple copies of the same name, but it doesn't matter which you select, since only the name is stored. Do you think it would be better to filter out the duplicate strings in the menu if the first match is intended to be the correct one?
I'm still seeing a crop 1.3 entry being selected from the database although my camera is a 1.6 crop but I think it might be caused by some inconsistent naming for that lens in the lensfun database coupled with some local calibration data that I've added. I'll have another look into it. Thanks, Graeme On 16 June 2016 at 16:46, Torsten Bronger <bron...@physik.rwth-aachen.de> wrote: > Hallöchen! > > Graeme Leese writes: > > > [...] > > > > Possibly, although I'm not sure that quite addresses this > > case. Following Torsten's commit darktable now gets a list of 3 > > lenses that match the exif in the raw file and it makes a menu of > > the three in the correction module GUI. When I make a selection > > from the menu it copies the name into the module parameters, but > > all the lenses have the same name, "Canon EF 50mm f/1.8 Mk ii" (or > > similar). > > If the lenses share the very same name, they should differ in crop > factor, so there is always a stable best match. > > Tschö, > Torsten. > > -- > Torsten Bronger Jabber ID: torsten.bron...@jabber.rwth-aachen.de > > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
