I have always wondered why "off" modules were included in the compressed history stack so I'm in favour of having them removed. When you compress the history stack, you lose the details of the history that took you to the final stage so losing the "off" modules should be a no-brainer.
On Mon, Jun 10, 2019 at 9:05 AM <dt-l...@stefan-klinger.de> wrote: > Hi, > > I've drafted [1] an implementation to make "compress history stack" to > also remove all unused modules, i.e., the ones switched off. But > there are some questions: > > 1. This was so easy to do, maybe it's a bad idea to do this at all? > > 2. I have derived the SQL from looking at other statements in the > source. I have no deep knowledge about DT's architecture, so > someone needs to verify that the query does not mess with other > stuff. > > 3. I think deleting unused modules should be optional. How should I > implement that? > > * There could be a checkbox "remove unused moduls" next to the > "compress history stack" button. I think this is the most > simple option. > > * Maybe "remove unused moduls" and "compress history stack" > should be entirely separate operations? I'm not sure about > the exact semantics though: What, precisely, should the > former do without the latter? Maybe delete all mentions of a > module below and up to the one where it's switched off? > > * Maybe the (currently unused) "presets" menu of darktable's > "history" module should be used to host these operations? > > Cheers, > Stefan > > ____________________ > [1] > https://github.com/darktable-org/darktable/compare/master...s5k6:compressHistory > > > > -- > http://stefan-klinger.de o/X > I prefer receiving plain text messages, not exceeding 32kB. /\/ > \ > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
