> Patrick Shanahan (2019-Jun-11, excerpt): > > important is to not *break* already processed images by a change. > > Yes, I'm aiming at that. AFAIK, my current implementation would not > break anything, see below. (The implementation reachable from > lighttable, which is already in master and was not built by me, can > break images, do so in bulk mode, not undoable, and without showing > the effect in lighttable). > > Edgardo Hoszowski (2019-Jun-11, excerpt): > > I usually want to keep the (off) modules when compressing history, > > so the current behavior should be kept. > > My implementation is default-off, and will only differ from how it's > currently done when explicitly enabled. > > > As already said somewhere here, some (off) modules can't be removed > > from history, or it will change the edit. > > My implementation already takes care about all these exceptional > modules I'm aware of: parafin has pointed out "highlight > reconstruction" and "white balance". There's also "orientation" which > internally seems to be done by the same module as "highlight > reconstruction". >
My point is that you should use the setting instead of hard-codding the modules. > Would anyone feel inclined to test this? > > https://github.com/s5k6/dt-test/tree/compressHistory > > > -- > http://stefan-klinger.de o/X > I prefer receiving plain text messages, not exceeding 32kB. /\/ > \ > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org > > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
