Modified again, thanks to a suggestion by Aurélien. I made a testing version (found on my pull request https://github.com/darktable-org/darktable/pull/3121) with 3 vibrance sliders to compare the effects of the different formulas. At the moment only on non-OpenCL version. I checked the effect on different images and I don't see lot of difference for the 3 formulas (except they aren't well balanced - some have a stronger effect). Anyway, on my test images I see no visible hue shift. I think the first one affects the most the other parameters of the image (hue, contrast), so I have a slight preference for the vibrance2/vibrance3 sliders. What do you think? >From a computing point of view, the first two should be marginally faster... Waiting for your opinions and further ideas!
On Fri, Oct 11, 2019 at 6:53 PM Keresztes Barna <kba...@gmail.com> wrote: > Pull request done! > First I wanted to make sure everything was okay. > Thanks again for the suggestions on the vibrance formula! > > On 11/10/2019 18:33, Pascal Obry wrote: > > If you want to have a little chance that this be tested please create a > > pull-request on the main darktable GitHub. > > > > Thanks, > > > > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
