Thank you, Heiko.
On 6/8/21 3:44 PM, Heiko Bauke wrote:
if I understand you correctly than the main change that you have
applied is that the 'auto' button is automatically applied when the
module is enabled. Though, this might be useful in your specific
application and workflow, I do not think that is reasonable in general.
Yes. This is one of the changes. Otherwise, the process requires
enabling the module, changing to independent channels, setting "preserve
colors" to none, then clicking on each channel and running auto on each
one, followed by manually adjusting the levels further if required. I
looked into attempting to write some LUA script to automate this, but
didn't have enough information for pursuing that course. Is there some
other method you would recommend?
The effect of the auto button depends on the histogram of the image
along the module stack when the image reaches the rgb levels module.
I.e., it depends on all modules before rgb levels. Therefore one
might get very inconsistent results that depend on the order of which
modules are enabled within a workflow.
This is already true, correct? Does a module always receive an original
image with which to work? Or does each module receive a transformed
image? I don't believe I'm making any changes to that behavior, unless
you're referring to using the histogram rather than the image for making
decisions about how to autoset the levels in each channel, and that the
histogram somehow changes differently.
Generally, I prefer when modules have a neutral effect when a module
is activated with its default settings.
Understood, but don't other modules already behave this way? E.g.,
denoise? Are you advocating that the code changes I make remain in a
separate module, therefore, so that rgblevels can remain neutral when
activated, but that agecorrect can make its changes when activated? Or
are you suggesting that no module should make changes to an image when
activated, but only after some other sort of manipulation occurs?
Granted, the color-correction that I need is less delicate than the
sophisticated transformations that darktable can produce, but if there's
no desire to incorporate such tools, I'm content to maintain my own
private copy, should that be the consensus.
Bret
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
