Hi there!
I am very pleased using darktable, thank you guys! If possible I would
like to contribute with building and testing on OS X.
Currently I am running OS X 10.6 (Snow Leopard) with dependencies
supplied by Homebrew instead of MacPorts. I just had to pick cairo and
pango with the option --without-x and pretty much everything else was
available and is working OK.
Since then I am comping dt from git master and tested the translation to
Brazilian Portuguese which I sent previously to this list.
So far the only issue I had is with the geotagging library. I IMHO the
USE_GEO switch should also condition the geotagging compilation. See the
patch down below.
But the real issue happens when the USE_GEO is set, the compilation
aborts with the following:
--error--
[ 70%] Building C object src/libs/CMakeFiles/geotagging.dir/geotagging.c.o
Linking C shared module libgeotagging.so
Undefined symbols:
"_getline", referenced from:
_gui_init in geotagging.c.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[2]: *** [src/libs/libgeotagging.so] Error 1
make[1]: *** [src/libs/CMakeFiles/geotagging.dir/all] Error 2
make: *** [all] Error 2
--error--
This is odd, but apparently Apple doesn't ship the getline function on
it's headers [1],[2].
What do you guys think is best? Supply getline or try to use the Apple's
fgetln which has a slightly different signature?
Do you prefer this kind of report on the bug-tracker or here on the list?
Best regards,
Guilherme
References:
[1] https://wiki.cs.columbia.edu/display/res/getline%28%29+missing
[2]
https://bitbucket.org/yt_analysis/yt/issue/319/cannot-link-stdio-getline-with-apple-gcc
--patch--
---
src/libs/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libs/CMakeLists.txt b/src/libs/CMakeLists.txt
index a6471fd..ebf8c79 100644
--- a/src/libs/CMakeLists.txt
+++ b/src/libs/CMakeLists.txt
@@ -81,7 +81,6 @@ if(USE_GEO)
add_library(location MODULE "location.c")
add_library(map_settings MODULE "map_settings.c")
set(MODULES ${MODULES} location map_settings)
-endif(USE_GEO)
if(Glib_PKGCONF_VERSION VERSION_EQUAL "2.26.0" OR
Glib_PKGCONF_VERSION VERSION_GREATER "2.26.0")
add_library(geotagging MODULE "geotagging.c")
@@ -89,6 +88,7 @@ if(Glib_PKGCONF_VERSION VERSION_EQUAL "2.26.0" OR
Glib_PKGCONF_VERSION VERSION_
else()
message(STATUS "glib version ${Glib_PKGCONF_VERSION} found. you
need at least 2.26.0 to compile the geotagging module.")
endif()
+endif(USE_GEO)
# Add libs references
foreach(module ${MODULES})
--
--patch--
------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
