Another simple fix would be to change line 125 in darkroom.c:expose() to if(dev->gui_synch && !dev->image_loading)
That way dt_iop_gui_update() is only executed after image is completely loaded, which implies that all parameters are available and blend gui is set correctly. Ulrich Am 04.11.2012 08:35, schrieb johannes hanika: > aha. i guess that line should rather go into dt_dev_reload_image > (around 334 same file). maybe that's the reason for the issues houz > had the other day, with gui_update() being called and sometimes not.. > depending on moon phase. gui_synch is a flag that tells the gui thread > later on to call gui_update() (synchronize gui elements with what the > core says the values should be). > > j. > > On Sun, Nov 4, 2012 at 11:45 AM, Ulrich Pegelow > <[email protected]> wrote: >> Short addition: all problems seem to be gone if dev->gui_synch is not >> set in line 264 of develop.c >> >> Ulrich >> >> Am 03.11.2012 23:18, schrieb Ulrich Pegelow: >>> Hi, >>> >>> maybe someone can help me here. It's a complicated thing about ui updates. >>> >>> There is an issue with expansion of blend controls when you open an >>> image in darkroom mode. >>> >>> Let's say you have an image with module highpass activated, with blend >>> mode "overlay" and with conditional blending set to active. >>> >>> Module highpass is the only one expanded at the moment. >>> >>> You go back to lighttable. Then you re-enter darkroom-mode on that >>> specific image. But now blend controls are not displayed properly! >>> Display shows blend mode "off" and no further controls are displayed :( >>> >>> According to my investigations this is due to the fact that >>> dt_iop_gui_update(module) is called from darkroom.c:expose(). When this >>> is done, blend mode settings are not correct (blend_params->mode is 0). >>> >>> Why does this happen. darkroom.c:expose() only does this if >>> dev->gui_synch is 1. What's the rationale behind? >>> >>> Hoping for some insight :) >>> >>> Ulrich ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
